Add support for NewPing #1116
Add support for NewPing #1116
Conversation
|
Quick note: TRAVIS02 (in hardware.h) still has HCSR04_SUPPORT. edit: hcsr04 board that I had successfully works with this. |
code/espurna/sensor.ino
Outdated
| sensor->setEcho(HCSR04_ECHO); | ||
| SonarSensor * sensor = new SonarSensor(); | ||
| sensor->setEcho(SONAR_ECHO); | ||
| sensor->setIterations(SONAR_PING_ITERATIONS); |
There was a problem hiding this comment.
Typo. Should be SONAR_ITERATIONS
| @@ -112,6 +112,9 @@ | |||
| #define I2C_SDA_PIN 12 // D6 | |||
| #define I2C_SCL_PIN 14 // D5 | |||
|
|
|||
| #define SONAR_TRIGGER 12 // D6 | |||
| #define SONAR_ECHO 13 // D7 | |||
|
|
|||
There was a problem hiding this comment.
Maybe just keep as defaults in sensor.h?
There was a problem hiding this comment.
Agree, these should not be here.
There was a problem hiding this comment.
Not sure I understood. sensors.h already has defaults. This is just the override for the Wemos. Is this incorrect?
There was a problem hiding this comment.
Oops. Pins on d1 do not include gpio 7 and 8 (6-11 are not mapped to pins at all so they do nothing): https://github.com/esp8266/Arduino/blob/master/variants/d1/pins_arduino.h
What i meant to say, change the defaults in hw.h to these and do not define them twice for wemos hw here. and note overlapping pin 12 for sda :) Sry for confusion
edit: ...phone autocomplete...
There was a problem hiding this comment.
@xoseperez I don't think these will work on Wemos — https://github.com/xoseperez/espurna/blob/dev/code/espurna/config/hardware.h#L2669-L2671. Wasn't this change correct after all?
There was a problem hiding this comment.
@ruimarinho nah you linked travis-only hw that is only a built test, no real boards involved. these are fine
espurna/code/espurna/config/sensors.h
Lines 570 to 576 in 4f61d3a
| @@ -112,6 +112,9 @@ | |||
| #define I2C_SDA_PIN 12 // D6 | |||
| #define I2C_SCL_PIN 14 // D5 | |||
|
|
|||
| #define SONAR_TRIGGER 12 // D6 | |||
| #define SONAR_ECHO 13 // D7 | |||
|
|
|||
There was a problem hiding this comment.
Agree, these should not be here.
code/espurna/sensor.ino
Outdated
| sensor->setEcho(HCSR04_ECHO); | ||
| SonarSensor * sensor = new SonarSensor(); | ||
| sensor->setEcho(SONAR_ECHO); | ||
| sensor->setIterations(SONAR_PING_ITERATIONS); |
ruimarinho
force-pushed
the
support/new-ping
branch
from
b24ee7c to
c49df00
Compare
* Works with many different ultrasonic sensor models: HC-SR04, SRF05, SRF06, DYP-ME007, JSN-SR04T & Parallax PING)))™. * Built-in digital filter method ping_median() for easy error correction (use SONAR_ITERATIONS build flag to configure). * Allows setting of a maximum distance where pings beyond that distance are read as no ping or clear (use SONAR_MAX_DISTANCE build flag).
ruimarinho
force-pushed
the
support/new-ping
branch
from
c49df00 to
43abc6b
Compare
|
Rebased and fixed some comments. |
SONAR_ITERATIONSbuild flag to configure).SONAR_MAX_DISTANCEbuild flag).