Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: stop parameter leads to failure with transformers backend #2663

Merged
merged 5 commits into from
Dec 13, 2024
Merged

BUG: stop parameter leads to failure with transformers backend #2663

merged 5 commits into from
Dec 13, 2024

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Dec 13, 2024 •
edited
Loading

Fixes #2556
Here's the effect after fixing.
image

@XprobeBot XprobeBot added the bug Something isn't working label Dec 13, 2024
@XprobeBot XprobeBot added this to the v1.x milestone Dec 13, 2024
qinxuye
qinxuye approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit c6b064b into xorbitsai:main Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.x
Development

Successfully merging this pull request may close these issues.

qwen2-instruct chat failed if set stop parameter
3 participants
@ChengjieLi28 @qinxuye @XprobeBot