Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using an existing library for variable replacement to support multi-root workspaces #286

Open
smac89 opened this issue Feb 19, 2025 · 2 comments · May be fixed by #287
Open

Consider using an existing library for variable replacement to support multi-root workspaces #286

smac89 opened this issue Feb 19, 2025 · 2 comments · May be fixed by #287

Comments

@smac89
Copy link

smac89 commented Feb 19, 2025

Is your feature request related to a problem? Please describe.

The extension currently doesn't work well with multi-root workspaces due to being unable to understand the variables used to describe the path to a project root.

Describe the solution you'd like

Consider using https://github.com/DominicVonk/vscode-variables to replace the current replaceVars function, as it is able to resolve the correct paths for many of the existing variables.

Describe alternatives you've considered

No response

Additional context

This will make the plugin more robust and may also bring the following issues closer to being resolved:

@waruqi
Copy link
Member

waruqi commented Feb 19, 2025

I haven't had time to improve it recently, you can try it and open a pr.

@smac89 smac89 linked a pull request Feb 19, 2025 that will close this issue
@smac89
Copy link
Author

smac89 commented Feb 19, 2025

@waruqi #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants