Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant code & Tokenize issue #118

Open
JonathanZha47 opened this issue Jun 3, 2024 · 3 comments
Open

Redundant code & Tokenize issue #118

JonathanZha47 opened this issue Jun 3, 2024 · 3 comments

Comments

@JonathanZha47
Copy link

  1. Seems like there's a redundant code here.
    image
  2. Tokenize method not working well for creating correct instruction_mask column
    image
@JonathanZha47
Copy link
Author

For the second problem, it appeared when I was using the 2.7.0 version of the sentence_transformers.

@JonathanZha47
Copy link
Author

If I'm using the 3.0.0 version of the sentence_transformers, then the local file issue still exists even if I change my code according to the #115 or #113

@BBC-Esq
Copy link
Contributor

BBC-Esq commented Aug 25, 2024

After you pip install the normal instructor package, try replacing the instructor.py file in the site-packages folder with the one in my fork here...let me know if this fixes the issue:

https://github.com/BBC-Esq/instructor-embedding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonathanZha47 @BBC-Esq