Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from go-bindata to embed #10

Closed
2 tasks done
karashiiro opened this issue Mar 17, 2021 · 2 comments
Closed
2 tasks done

Migrate from go-bindata to embed #10

karashiiro opened this issue Mar 17, 2021 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@karashiiro
Copy link
Member

karashiiro commented Mar 17, 2021 •
edited
Loading

Why?

  • embed is part of the standard library, so we can kick a dependency.
  • generate.sh can then be removed.
  • The repository size would be dramatically reduced, since selectors.go would be removed.

What needs to happen

  • Upgrade from Go v1.15 to v1.16
  • Bump the project version from v2 to v3
@karashiiro karashiiro added the dependencies Pull requests that update a dependency file label Mar 17, 2021
@karashiiro karashiiro changed the title Migrate from go-bindata to embed Migrate from go-bindata to embed Mar 17, 2021
@karashiiro karashiiro added this to the v3 milestone Mar 17, 2021
@karashiiro karashiiro pinned this issue Mar 17, 2021
@karashiiro
Copy link
Member Author

Closed with 51613dc

@karashiiro
Copy link
Member Author

Rolled back; you can't have submodules in a go library, and I'm not going to copy the files manually.

@karashiiro karashiiro removed this from the v3 milestone Apr 5, 2021
@karashiiro karashiiro unpinned this issue Apr 5, 2021
@karashiiro karashiiro mentioned this issue Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karashiiro