Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive: navigate to layout actions which create a loop cause XMDS to crash #2984

Closed
dasgarner opened this issue Jan 10, 2023 · 0 comments · Fixed by xibosignage/xibo-cms#1543
Closed

Interactive: navigate to layout actions which create a loop cause XMDS to crash #2984

dasgarner opened this issue Jan 10, 2023 · 0 comments · Fixed by xibosignage/xibo-cms#1543
Assignees
@PeterMis
Labels
bug regression
Milestone
3.3.3

Comments

@dasgarner
Copy link
Member

If Layout A has an action to Layout B and Layout B has an action to Layout A, this causes an endless loop in code, which involves a DB lookup each look and eventually a server crash.
@dasgarner dasgarner added this to the 3.3.3 milestone Jan 10, 2023
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Jan 10, 2023
@PeterMis
Interactive : navigate to Layout action, fix potential infinite loop.
4430a3a 
Fixes xibosignage/xibo#2984
@PeterMis PeterMis mentioned this issue Jan 10, 2023
Merged
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Jan 16, 2023
@PeterMis
Interactive : navigate to Layout action, better handle already proces…
d5e8d30 
…sed Layouts

xibosignage/xibo#2984
PeterMis added a commit to xibosignage/xibo-cms that referenced this issue Jan 17, 2023
@PeterMis
Interactive : navigate to Layout action, fix potential infinite loop. (…
21cb023 
…#1543)

* Interactive : navigate to Layout action, fix potential infinite loop.
Fixes xibosignage/xibo#2984

* Interactive : navigate to Layout action, better handle already processed Layouts
xibosignage/xibo#2984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug regression
Projects
None yet
Milestone
3.3.3
Development

Successfully merging a pull request may close this issue.

Interactive : navigate to Layout action, fix potential infinite loop. PeterMis/xibo-cms
2 participants
@dasgarner @PeterMis