Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectors: Fix duplicate data on dropdown option #2741

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Connectors: Fix duplicate data on dropdown option #2741

merged 2 commits into from
Oct 2, 2024

Conversation

mgbaybay
Copy link
Contributor

Changes

  • Connectors: Fix for issue on using pagedSelect dropdown
  • Used localSelect instead to display all options at once

Relates to: xibosignage/xibo#3505

@mgbaybay mgbaybay self-assigned this Sep 19, 2024
@mgbaybay mgbaybay requested a review from dasgarner September 19, 2024 06:08
dasgarner
dasgarner previously approved these changes Sep 19, 2024
View reviewed changes
@dasgarner
Copy link
Member

We should also test any core widgets which use this functionality, e.g. the Dashboard Widget, SSP connector, etc

@mgbaybay mgbaybay requested a review from dasgarner October 1, 2024 16:07
@dasgarner dasgarner requested review from maurofmferrao and removed request for dasgarner October 1, 2024 16:10
maurofmferrao
maurofmferrao approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ifarzana
Copy link
Contributor

ifarzana commented Oct 2, 2024

TEST: /Display END

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/11141181480

@mgbaybay mgbaybay merged commit e769d3f into develop Oct 2, 2024
3 checks passed
@mgbaybay mgbaybay deleted the bugfix/kopff_fix_connector_dropdown_pagination branch October 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasgarner dasgarner dasgarner approved these changes

@maurofmferrao maurofmferrao maurofmferrao approved these changes

Assignees

@mgbaybay mgbaybay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgbaybay @dasgarner @ifarzana @maurofmferrao