Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout Preview: Fix text element fit to selection #2704

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Layout Preview: Fix text element fit to selection #2704

merged 1 commit into from
Aug 12, 2024

Conversation

rubenberttpingol
Copy link
Contributor

@rubenberttpingol rubenberttpingol self-assigned this Aug 12, 2024
dasgarner
dasgarner approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the understanding we will create a new issue to refactor so that we do not need this type of conditional logic.

@rubenberttpingol
Copy link
Contributor Author

Approved on the understanding we will create a new issue to refactor so that we do not need this type of conditional logic.

Opened a ticket for this here
https://github.com/xibosignageltd/xibo-private/issues/834

@ifarzana
Copy link
Contributor

TEST: /Layout END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/10355914489

@ifarzana
Copy link
Contributor

TEST:/Layout/Editor/layout_editor_rss_ticker.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/10356013868

@rubenberttpingol rubenberttpingol merged commit 6286621 into develop Aug 12, 2024
2 checks passed
@rubenberttpingol rubenberttpingol deleted the bugfix/layout_preview_text_element_fit_to_selection branch August 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasgarner dasgarner dasgarner approved these changes

Assignees

@rubenberttpingol rubenberttpingol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenberttpingol @ifarzana @dasgarner