Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out the schedule monitoring from Schedule class #631

Closed
pdewouters opened this issue Dec 9, 2014 · 4 comments
Closed

Extract out the schedule monitoring from Schedule class #631

pdewouters opened this issue Dec 9, 2014 · 4 comments

Comments

@pdewouters
Copy link
Contributor

The HMBKP_Scheduled_Backup class has too many responsibilities.

One functionality we can abstract out is the status monitoring.

Schedules could publish status to subscribed objects using the Observer pattern. We could have a single Backup_Monitor class or whatever that would have a collection of all running backups, and handle status changes. It would maybe make it easier to have parallel running backups with Backdrop.

Why are we writing status to a file? Could it not be a DB option?

Ha, actually suggested by Scrutinizer
https://scrutinizer-ci.com/g/humanmade/backupwordpress/code-structure/master/class/%2Bglobal%5CHMBKP_Scheduled_Backup

Thoughts? @willmot

@pdewouters pdewouters self-assigned this Dec 9, 2014
@pdewouters pdewouters added this to the Future Release milestone Dec 9, 2014
@willmot
Copy link
Contributor

willmot commented Dec 10, 2014

Huge +1

@willmot
Copy link
Contributor

willmot commented Dec 18, 2014

Feel the same about HM_Backup

@willmot
Copy link
Contributor

willmot commented Jan 5, 2015

Also see #667.

Why are we writing status to a file? Could it not be a DB option?

Because DB connections can go away, generally the FS is more reliable.

@willmot
Copy link
Contributor

willmot commented Nov 30, 2015

Done as part of #936

@willmot willmot closed this as completed Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants