Crash if clicking play audio maniacally fast (or the computer is too slow)

[shenlebantongying]

To reproduce easier, try to add a sanitizer to slow down.

add_compile_options(-fno-omit-frame-pointer -fsanitize=address)
add_link_options(-fno-omit-frame-pointer -fsanitize=address)

Add a sound folder with a single sound -> https://upload.wikimedia.org/wikipedia/commons/5/52/En-us-hello.ogg

The problem is the operator = of std::shared_ptr will destroy the previous owned data first. https://en.cppreference.com/w/cpp/memory/shared_ptr/operator%3D

The emit cancelPlaying( false ); doesn't imply the thread will shut down immediately.

If the computer is slow enough, or someone clicks too fast, thread = std::make_shared< DecoderThread >( audioData, this ); will try to delete a running QThread and give this message QThread: Destroyed while thread is still running

goldendict-ng/src/ffmpegaudio.cc

Lines 54 to 56 in ebce607

	emit cancelPlaying( false );
	QByteArray audioData( ptr, size );
	thread = std::make_shared< DecoderThread >( audioData, this );

Screen.Recording.2024-03-19.at.8.35.45.PM.mov