Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling page doesn't work on thumbnails on mobile devices #107

Closed
twanschik opened this issue Oct 14, 2016 · 5 comments
Closed

Scrolling page doesn't work on thumbnails on mobile devices #107

twanschik opened this issue Oct 14, 2016 · 5 comments
Assignees
@xiaolin
Labels
bug

Comments

@twanschik
Copy link
Contributor

It seems like the call event.preventDefault() in slideToIndex() prevents scrolling of a page when on mobile devices (via touchstart).
@xiaolin
Copy link
Owner

xiaolin commented Oct 17, 2016 •
edited
Loading

Thats odd, If you go on the demo page using a mobile device I can scroll just fine.

@twanschik
Copy link
Contributor Author

Try to scroll by "touchstarting" on a thumbnail. Doing so will lead the event.preventDefault call.

@xiaolin
Copy link
Owner

xiaolin commented Oct 18, 2016

Ah I see the issue now.

@xiaolin xiaolin added the bug label Oct 18, 2016
@xiaolin
Copy link
Owner

xiaolin commented Oct 22, 2016

I will fix this by removing the onTouchStart events since it is no longer needed.
facebook/react#6221 (comment)

@xiaolin xiaolin self-assigned this Oct 22, 2016
xiaolin added a commit that referenced this issue Oct 22, 2016
@xiaolin
Remove remaining onTouchStart events #107
5b58388
@xiaolin
Copy link
Owner

xiaolin commented Oct 22, 2016

fixed in 0.7.3

@xiaolin xiaolin closed this as completed Oct 22, 2016
xiaolin added a commit that referenced this issue Jul 21, 2023
@xiaolin
Remove remaining onTouchStart events #107
544a0d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaolin xiaolin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twanschik @xiaolin