New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] access_token expires sooner than said by expires_in and expires_at #24

Closed

solsticedhiver opened this issue Jul 18, 2016 · 10 comments

Assignees

Labels

bug

Contributor

solsticedhiver commented Jul 18, 2016 •

edited by qk7b

Loading

If one get an acess token with the REST API at https://cloud.xee.com/v3/auth/access_token

One get as result something like ```

{
    "access_token":"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "token_type":"bearer",
    "expires_in":13060800,
    "expires_at":1481904143,
    "refresh_token":"yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy"
}

1481904143 means 2016-12-16 at 17:02:23
But the token expires just minutes or an hour after creation.

13060800 means 151 days

It is not an error in documentation but implementatoin but there is nowhere to mention that.

solsticedhiver changed the title ~~expiry of access token is wrong in expires_in and expires_at between reality of expiry of the token~~ access_token expires sooner than said by expires_in and expires_at

Contributor

josephpage commented Jul 19, 2016 •

edited

Loading

Oh ! ... I thought this was a bug of oauth2 gem.

To temporary bypass it, I catch the EXPIRED_TOKEN error from Xee API, then
refresh tokens and retry the request.

Wish Xee will fix it soon.

Contributor

alexjomin commented Jul 19, 2016

Hi Guys,

Thank you for your feedback. We are aware of this issue, we are working on it !

alexjomin added the bug label

alexjomin self-assigned this

Contributor

josephpage commented Aug 8, 2016

Thank you for working on it.
Can you communicate a patch release date ?

Contributor

qk7b commented Aug 8, 2016

No date right now but we've planned to fix it this week !

qk7b changed the title ~~access_token expires sooner than said by expires_in and expires_at~~ [Auth] access_token expires sooner than said by expires_in and expires_at

Contributor

qk7b commented Aug 9, 2016

We found something. A fix is in progress, we'll keep you informed !

vosmont commented Aug 9, 2016

Great news !

Contributor

qk7b commented Aug 9, 2016

The bug has been fixed!

Summary:

Now, all the tokens will expire after 48h (including the tokens provided before this post)
Once refreshed, the new ones will be ok !

We made a post about it

qk7b closed this as completed

Contributor

josephpage commented Aug 9, 2016

We will open the Champagne !

vosmont commented Aug 11, 2016

I can confirm that it works well now.
The tokens are valid for 48h (it was 1h)... much more suitable for an Home Automation system !

Contributor

qk7b commented Aug 11, 2016

Thank you for the feedback :)

josephpage mentioned this issue

[Auth] Refresh Tokens expire abnormally and API respond with "invalid request" #82

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment