Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for example data to CI #49

Merged
merged 11 commits into from
Oct 23, 2019
Merged

Add tests for example data to CI #49

merged 11 commits into from
Oct 23, 2019

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Oct 15, 2019 •
edited
Loading

WIP: trying to implement testing using data in the example-files repo. Closes #38.

@cbrnr cbrnr marked this pull request as ready for review October 15, 2019 06:10
@cbrnr cbrnr changed the title Clone example data repo on Azure Add tests for example data to CI Oct 15, 2019
@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 15, 2019

@cboulay @tstenner tests on Azure work. We can now start adding more (small) test files to our example-files repo and they will be automatically smoke-tested (specific tests regarding the file contents need to be added manually).

@cbrnr cbrnr requested a review from tstenner October 21, 2019 14:15
@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 22, 2019

@tstenner could you review this PR and merge if you're happy? We have some nice changes already and I'd like to release 1.16.2 as soon as this gets merged.

tstenner
tstenner approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@tstenner tstenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nitpicks, otherwise LGTM

azure-pipelines.yml Outdated Show resolved Hide resolved
pyxdf/test/test_data.py Outdated Show resolved Hide resolved
pyxdf/test/test_data.py Show resolved Hide resolved
@cbrnr cbrnr merged commit 8705120 into xdf-modules:master Oct 23, 2019
@cbrnr cbrnr deleted the test_data branch October 23, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstenner tstenner tstenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrnr @tstenner