Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for __init__.py #71

Closed
mzfr opened this issue May 5, 2018 · 3 comments
Closed

Check for __init__.py #71

mzfr opened this issue May 5, 2018 · 3 comments
Labels

Comments

@mzfr
Copy link
Contributor

mzfr commented May 5, 2018

We Should have a check for init.py file.
The main reason is that When we run pylint on any folder it first checks for init.py file in it. If the file is missing then it produce an error

This is the error:
screenshot_20180505_202420

This is a know problem in pylint.

@razzeee
Copy link
Member

razzeee commented May 5, 2018

I would rather hope for them to fix it then add this hack to our codebase :/
Pretty much every addon will fails that check, as you only need that file for subfolders in kodi land.

@mzfr
Copy link
Contributor Author

mzfr commented May 6, 2018

@razzeee yes but as you can see there in comments that this issue haven't been fixed since last year.
So I think instead of leaving this issue we can come up with not so good and temporary solution i.e we can have a check for init.py file and if the file is missing we can just add the file to the addon. Now this is not a very good solution but this seems the only possible solution for now.

We can remove this check the moment that issue get fixed.

@mzfr
Copy link
Contributor Author

mzfr commented Aug 12, 2018

@razzeee We don't need this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants