Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin dask #280

Closed
aaronspring opened this issue Mar 9, 2021 · 3 comments · Fixed by #286
Closed

unpin dask #280

aaronspring opened this issue Mar 9, 2021 · 3 comments · Fixed by #286

Comments

@aaronspring
Copy link
Collaborator

#277 pins dask==2021.02.0 some errors occur in contingency

Don’t understand what’s the problem with the March version https://docs.dask.org/en/latest/changelog.html

Originally posted by @aaronspring in #277 (comment)

@raybellwaves
Copy link
Member

test_contingency.py and test_probabilistic.py failing

@raybellwaves
Copy link
Member

Is there a pytest CLI command you can use to specify args to a function? A quick way is to edit the values in the @pytest.mark.parametrize

@raybellwaves
Copy link
Member

Output of test_Contingency_table with chunked_da, time, np.array([-np.inf, 0.5, np.inf] gives

xskillscore/core/contingency.py:122: in __init__
    self._table = self._get_contingency_table(dim)
xskillscore/core/contingency.py:161: in _get_contingency_table
    table = histogram(
xskillscore/core/utils.py:166: in histogram
    return xhist(*args, bins=bins, **kwargs)
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/xhistogram/xarray.py:133: in histogram
    h_data = _histogram(*args_data, weights=weights_data, bins=bins, axis=axis,
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/xhistogram/core.py:261: in histogram
    bin_counts = _histogram_2d_vectorized(*all_args_reshaped, bins=bins,
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/xhistogram/core.py:133: in _histogram_2d_vectorized
    bin_counts = _dispatch_bincount(bin_indices, weights, N, hist_shapes,
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/xhistogram/core.py:81: in _dispatch_bincount
    return _bincount_2d(bin_indices, weights, N, hist_shapes)
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/xhistogram/core.py:32: in _bincount_2d
    return bc_offset.reshape(final_shape)
../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/dask/array/core.py:1919: in reshape
    return reshape(self, shape, merge_chunks=merge_chunks)

        if reduce(mul, shape, 1) != x.size:
>           raise ValueError("total size of new array must be unchanged")
E           ValueError: total size of new array must be unchanged

../../../miniconda3/envs/xskillscore-dev/lib/python3.8/site-packages/dask/array/reshape.py:206: ValueError

@aaronspring aaronspring mentioned this issue Mar 21, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants