Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet-linker] Add a CollectUnmarkedMembersStep that will keep linked away types around for the static registrar. #9722

Merged
merged 2 commits into from
Sep 29, 2020
Merged

[dotnet-linker] Add a CollectUnmarkedMembersStep that will keep linked away types around for the static registrar. #9722

merged 2 commits into from
Sep 29, 2020

Commits on Sep 29, 2020

  1. [dotnet-linker] Add a CollectUnmarkedMembersStep that will keep linke… 

    …d away types around for the static registrar.

The static registrar may need access to types that have been linked away, so
store unmarked types so that the static registrar can access them later.

This also makes all the monotouch-test variations green, so enable them all.

Fixes this monotouch-test when all optimizations are enabled:

    MonoTouchFixtures.ObjCRuntime.RegistrarTest
        [FAIL] TestProtocolRegistration :   UIApplicationDelegate/17669
            Expected: True
            But was:  False
                at MonoTouchFixtures.ObjCRuntime.RegistrarTest.TestProtocolRegistration() in xamarin-macios/tests/monotouch-test/ObjCRuntime/RegistrarTest.cs:line 1350
    @rolfbjarne
    rolfbjarne committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    19eb4a5 View commit details
    Browse the repository at this point in the history

  2. Unignore the right configuration.

    @rolfbjarne
    rolfbjarne committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    28e697a View commit details
    Browse the repository at this point in the history