Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Share the Pack/UnpackLibraryResources targets between Xamarin.iOS and Xamarin.Mac. #9471

Merged

Commits on Aug 24, 2020

  1. [msbuild] Share the Pack/UnpackLibraryResources targets between Xamar…

    …in.iOS and Xamarin.Mac.
    
    There were 2 differences that had to be reconciled:
    
    * The Xamarin.Mac version took 'IntermediateOutputPath' as the intermediate
      output path, while the Xamarin.iOS version used
      'DeviceSpecificIntermediateOutputPath'.
      'DeviceSpecificIntermediateOutputPath' is defined to be
      'IntermediateOutputPath' for Xamarin.Mac, so make the shared version use
      'DeviceSpecificIntermediateOutputPath', since that works in both cases.
    
    * The Xamarin.Mac version was writing the output of PackLibraryResources to
      the FileWrites item group. This was removed on purpose from the Xamarin.iOS
      version in e97d69b, so it seemed best to
      leave it out in the shared version as well.
    
    Also re-use the _EmbeddedResourcePrefix variable to determine the resource prefix.
    rolfbjarne committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    823fb93 View commit details
    Browse the repository at this point in the history