Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoFill CredentialProvider NSExtensionPoint support #9030

Merged

Conversation

kiddailey
Copy link
Contributor

This commit adds support for AutoFill Credential Provider extensions to be built. Specifically, this resolves the issue with unrecognized extension point warnings being issued during the build process for Credential Providers. A related change to Xamarin.MacDev has already been merged.

For more information, see posted issue at: #9000

@rolfbjarne
Copy link
Member

build

@spouliot spouliot added the community Community contribution ❤ label Jul 8, 2020
@chamons
Copy link
Contributor

chamons commented Jul 8, 2020

Great stuff - thanks for the contribution!

@mandel-macaque
Copy link
Member

Will backport this do d16-8 and will do an insertion with it so that is available ASAP.

@monojenkins
Copy link
Collaborator

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry here too?

<key>iOS</key>
<dict>
<key>com.apple.ui-services</key>
<string>8.0</string>
<key>com.apple.services</key>
<string>8.0</string>
<key>com.apple.keyboard-service</key>
<string>8.0</string>
<key>com.apple.fileprovider-ui</key>
<string>8.0</string>
<key>com.apple.fileprovider-nonui</key>
<string>8.0</string>
<key>com.apple.photo-editing</key>
<string>8.0</string>
<key>com.apple.share-services</key>
<string>8.0</string>
<key>com.apple.widget-extension</key>
<string>8.0</string>
<key>com.apple.watchkit</key>
<string>8.2</string>
<key>com.apple.AudioUnit-UI</key>
<string>8.2</string>
<key>com.apple.AudioUnit</key>
<string>8.0</string>
<key>com.apple.Safari.content-blocker</key>
<string>9.0</string>
<key>com.apple.Safari.sharedlinks-service</key>
<string>9.0</string>
<key>com.apple.spotlight.index</key>
<string>9.0</string>
<key>com.apple.networkextension.packet-tunnel</key>
<string>9.0</string>
<key>com.apple.callkit.call-directory</key>
<string>10.0</string>
<key>com.apple.intents-service</key>
<string>10.0</string>
<key>com.apple.intents-ui-service</key>
<string>10.0</string>
<key>com.apple.message-payload-provider</key>
<string>10.0</string>
<key>com.apple.usernotifications.content-extension</key>
<string>10.0</string>
<key>com.apple.usernotifications.service</key>
<string>10.0</string>
</dict>

This is used by the IDEs when listing the possible deployment targets for an extension.

With that addition this should be good to go.

@kiddailey
Copy link
Contributor Author

Done and I think I've got it correct.

Thanks for pointing that out! I'm (slowly) gathering a list of missing extension points and am planning on putting in pull requests for those as well, so this definitely helps me make sure they're complete.

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect!

@rolfbjarne
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 90 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed Known issue: HE0038)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution ❤
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants