Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Harness] If we cannot connect over tcp use Console.Out as the writer. #8235

Merged
merged 3 commits into from
Apr 1, 2020
Merged

[Harness] If we cannot connect over tcp use Console.Out as the writer. #8235

merged 3 commits into from
Apr 1, 2020

Conversation

mandel-macaque
Copy link
Member

If we could not connect to the host via tcp, set the writer to be
Console.Out which will fix the NRE and will report the test run in the
runlogs.

Fix only applies to tvOS and iOS since neither watchOS or MacOS use the tcp connection.

fixes: #8130

@mandel-macaque
[Harness] If we cannot connect over tcp use Console.Out as the writer.
e9d7234 
If we could not connect to the host via tcp, set the writer to be
Console.Out which will fix the NRE and will report the test run in the
runlogs.

fixes: #8130
@mandel-macaque mandel-macaque added the run-bcl-tests Run the BCL tests label Mar 30, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

24 tests failed, 129 tests passed.

Failed tests

  • [NUnit] Mono BCL tests group 1/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 3/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 4/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 5/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemXunit/iOS Unified 32-bits - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 1/tvOS - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 2/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 3/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 4/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 5/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 2/tvOS - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemXunit/tvOS - simulator/Debug: BuildFailure

spouliot
spouliot approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be run on the internal bots before merging

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@mandel-macaque
Copy link
Member Author

@spouliot branch is in origin already.

@mandel-macaque mandel-macaque added the run-internal-tests If tests should be executed on the internal Jenkins instance. label Mar 31, 2020
@mandel-macaque
Copy link
Member Author

build

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@xamarin-release-manager
Copy link
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Running XM tests on '10.14'' 🔥

✅ Build succeeded
✅ Packages:

✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

5 tests failed, 180 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.)
  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.)
  • xammac tests/Mac Modern/Release: TimedOut (Execution timed out after 1200 seconds.)
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 4)
🔥 [Xamarin.Mac tests on 10.14 failed: null](https://jenkins.internalx.com/job/macios/job/PR-8235/2/display/redirect) 🔥

@xamarin-release-manager
Copy link
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages:

✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 183 tests passed.

Failed tests

  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 4)

@mandel-macaque mandel-macaque merged commit f16561b into master Apr 1, 2020
@mandel-macaque mandel-macaque deleted the issue-8130 branch April 1, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

@chamons chamons chamons approved these changes

Assignees
No one assigned
Labels
run-bcl-tests Run the BCL tests run-internal-tests If tests should be executed on the internal Jenkins instance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[xharness][bcl-tests] ArgumentNullException writing the XML
7 participants
@mandel-macaque @monojenkins @xamarin-release-manager @dalexsoto @rolfbjarne @spouliot @chamons