[d16-6]Bump to mono:2020-02 #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump mono to 2020-02 head to be in sync with Android. Co-authored-by: Imran Hameed <imhameed@microsoft.com> Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Sebastien Pouliot <sebastien.pouliot@gmail.com>
mandel-macaque
requested review from
chamons,
rolfbjarne and
spouliot
as code owners
|
Build failure 🔥 Build failed 🔥 |
| @@ -125,8 +125,8 @@ void ProcessMethod (MethodDefinition method) | |||
| } | |||
| } | |||
|
|
|||
| if (MarkStep.IsPropertyMethod (method)) { | |||
| var property = MarkStep.GetProperty (method); | |||
| if (method.IsPropertyMethod ()) { | |||
There was a problem hiding this comment.
Curious - why were these code changes necessary?
There was a problem hiding this comment.
we use external source from monolinker repo - which is not quite API stable
There was a problem hiding this comment.
Changes in the API of the linker.
whitneyschmidt
approved these changes
Mar 20, 2020
dalexsoto
approved these changes
Mar 20, 2020
spouliot
approved these changes
Mar 20, 2020
rolfbjarne
approved these changes
Mar 20, 2020
stephen-hawley
approved these changes
Mar 20, 2020
|
Build failure Test results5 tests failed, 166 tests passed.Failed tests
|
|
@monojenkins backport d16-6-xcode11.4 |
|
@dalexsoto backporting to d16-6-xcode11.4 failed, the patch results in conflicts: Please backport manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump mono to 2020-02 head to be in sync with Android.
Co-authored-by: Imran Hameed imhameed@microsoft.com
Co-authored-by: Sebastien Pouliot sebastien.pouliot@microsoft.com
Co-authored-by: Ankit Jain radical@gmail.com
Co-authored-by: Manuel de la Pena mandel@microsoft.com
Co-authored-by: Sebastien Pouliot sebastien.pouliot@gmail.com