Bring HttpClient from CoreFX. #7346

baulig · 2019-10-31T17:37:26Z

This bumps Mono to use mono/mono#17645 (which is the 2019-10 backport of mono/mono#17628).

The big user-visible change is in regards to certificate validation, everything below are just some minor adjustments to tests.

SocketsHttpHandler

CoreFX uses a completely new HttpClientHandler implementation called SocketsHttpHandler, which you can find here.

Since this is not based on the web stack anymore, it does not use any of the related APIs such as ServicePointManager or WebException.

Certificate Validation Changes

There is a new API called HttpClientHandler.ServerCertificateCustomValidationCallback. You can find the documentation here and the code here

The ServicePointManager.ServerCertificateValidationCallback is no longer invoked and on certificate validation failure, AuthenticationException (from System.Security.Authentication) is thrown instead of WebException.

At the moment, the NSUrlSessionHandler still uses it's own validation callback and also still throws WebException on failure; we should probably look into making this consistent with the other handlers.

Minor adjustments related to internal Mono APIs

HttpContent.SerializeToStreamAsync() is now protected (changed from protected internal).
- src/Foundation/NSUrlSessionHandler.cs: changed overload accordingly.
- src/System.Net.Http/CFContentStream.cs: likewise.
HttpHeaders.GetKnownHeaderKind() is an internal Mono API.
There is a new internal API called System.Net.Http.PlatformHelper.IsContentHeader(key) which exists in both the old as well as the new implementation.
The correct way of doing it with the CoreFX handler is
HeaderDescriptor.TryGet (key, out var descriptor) && descriptor.HeaderType == HttpHeaderType.Content

Minor adjustments to tests.

HttpClientHandler.MaxRequestContentBufferSize is now longer supported, you can set it to any non-negative value, the getter will always return 0. See the source code for details.
- tests/linker/ios/link sdk/HttpClientHandlerTest.cs: removed assertion from test.
HttpMessageInvoker.handler is a protected private field - in the CoreFX handler, it is called _handler and private. This is accessed via reflection by some of the tests, which are now using the new name.
- tests/mmptest/src/MMPTest.cs: here
- tests/mtouch/MTouch.cs: here
tests/monotouch-test/System.Net.Http/MessageHandlers.cs:
Adjust RejectSslCertificatesServicePointManager to reflect the certificate validation changes described above.
- FIXME: There was an Assert.Ignore() related to NSUrlSessionHandler and macOS 10.10;
  I removed that to reenable the test because the description linked to an old issue in the private repo that was referenced by several "Merged" PR's, so it looked to me that this might have already been fixed - and I also didn't see why it would fail there.

This bumps Mono to use mono/mono#17645 (which is the 2019-10 backport of mono/mono#17628). The big user-visible change is in regards to certificate validation, everything below are just some minor adjustments to tests. ## SocketsHttpHandler CoreFX uses a completely new `HttpClientHandler` implementation called `SocketsHttpHandler`, which you can find at https://github.com/dotnet/corefx/tree/release/3.0/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler. Since this is not based on the web stack anymore, it does not use any of the related APIs such as `ServicePointManager` or `WebException`. ## Certificate Validation Changes There is a new API called `HttpClientHandler.ServerCertificateCustomValidationCallback`. - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.servercertificatecustomvalidationcallback?view=netframework-4.8 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Unix.cs#L154 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Windows.cs#L383 The `ServicePointManager.ServerCertificateValidationCallback` is no longer invoked and on certificate validation failure, `AuthenticationException` (from `System.Security.Authentication`) is thrown instead of `WebException`. At the moment, the `NSUrlSessionHandler` still uses it's own validation callback and also still throws `WebException` on failure; we should probably look into making this consistent with the other handlers. ## Minor adjustments related to internal Mono APIs * `HttpContent.SerializeToStreamAsync()` is now `protected` (changed from `protected internal`). - src/Foundation/NSUrlSessionHandler.cs: changed overload accordingly. - src/System.Net.Http/CFContentStream.cs: likewise. * `HttpHeaders.GetKnownHeaderKind()` is an internal Mono API. There is a new internal API called `System.Net.Http.PlatformHelper.IsContentHeader(key)` which exists in both the old as well as the new implementation. The correct way of doing it with the CoreFX handler is `HeaderDescriptor.TryGet (key, out var descriptor) && descriptor.HeaderType == HttpHeaderType.Content` ## Minor adjustments to tests. * `HttpClientHandler.MaxRequestContentBufferSize` is now longer supported, you can set it to any non-negative value, the getter will always return 0. See https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Core.cs#L18. - tests/linker/ios/link sdk/HttpClientHandlerTest.cs: removed assertion from test. * `HttpMessageInvoker.handler` is a `protected private` field - in the CoreFX handler, it is called `_handler` and `private`. This is accessed via reflection by some of the tests, which are now using the new name. - tests/mmptest/src/MMPTest.cs: here - tests/mtouch/MTouch.cs: here * tests/monotouch-test/System.Net.Http/MessageHandlers.cs: Adjust `RejectSslCertificatesServicePointManager` to reflect the certificate validation changes described above. - FIXME: There was an `Assert.Ignore()` related to `NSUrlSessionHandler` and macOS 10.10; I removed that to reenable the test because the description linked to an old issue in the private repo that was referenced by several "Merged" PR's, so it looked to me that this might have already been fixed - and I also didn't see why it would fail there.

monojenkins · 2019-10-31T17:43:17Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

spouliot · 2019-10-31T18:07:47Z

Changes LGTM

WRT public Func<System.Net.Http.HttpRequestMessage,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Security.Cryptography.X509Certificates.X509Chain,System.Net.Security.SslPolicyErrors,bool> ServerCertificateCustomValidationCallback { get; set; }

we can't expose this in NSUrlSessionHandler without a huge impact on app size (about 1.3MB extra code, see #6103) as it brings most of the crypto stack in the app (which might not be needed in many cases).

However we can document how to map it with the existing certificate handler - so the price to pay becomes optional for people wanting to share/re-use the same code.

filipnavara · 2019-10-31T23:15:45Z

However we can document how to map it with the existing certificate handler - so the price to pay becomes optional for people wanting to share/re-use the same code.

Would it make sense to expose that as extension method? Presumably it would get linked out if not used.

spouliot · 2019-11-01T00:58:04Z

@filipnavara no, in this case that would not help. The reason is that it's a delegate used as a callback.

IOW the handler code (not the user code) has to create an X509Certificate2 and a X509Chain to be able to call the delegate (and your code). Even if the property is null it will be reachable (part of the code will check it for null).

Those types will recursively mark a lot of other (mostly security/crypto) types that most application are likely not using (if using the NSUrlSessionHandler for example).

This was the problem with the original approach in https://github.com/xamarin/xamarin-macios/pull/5733/files#diff-7f619be41b43eaaed811ff8b330f769cR511 that resulted in a 1.3MB app size increase.

The (existing) native handler version of the callback workaround this by using fewer types (mostly only SecTrust) that have nearly no other dependencies (p/invokes to native iOS functions).

The trick is (or will be) to set that (existing) delegate to call the one defined in the new handler, i.e. get the X509Certificate2 (and optionally a X509Chain, less useful for pinning) out of SecTrust and call the delegate. That way only people using the feature will pay the extra price (in app size).

filipnavara · 2019-11-01T02:43:06Z

Perhaps I should have been more clear but that approach still sounds like what I had in mind:

NSUrlSessionHandler would expose only callback with native macOS objects, as it does now
There would be IDisposable NSUrlSessionHandlerExtensions.RegisterServerValidationCallback(this NSUrlSessionHandler handler, Func<System.Net.Http.HttpRequestMessage,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Security.Cryptography.X509Certificates.X509Chain,System.Net.Security.SslPolicyErrors,bool> validationCallback) (or similar prototype) that would register a delegate that translates from native Cocoa objects into the X509* ones and call validationCallback

VincentDondain

👀

mandel-macaque · 2019-11-01T17:56:25Z

@spouliot we can adde the extension method, I can create a PR with it.

baulig · 2019-11-01T18:56:25Z

build

monojenkins · 2019-11-01T19:01:44Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

monojenkins · 2019-11-01T19:10:32Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

xamarin-release-manager · 2019-11-01T19:12:01Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2

🔥 Build failed 🔥

xamarin-release-manager · 2019-11-01T20:04:21Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Packaging' 🔥 : hudson.AbortException: script returned exit code 2

✅ Build succeeded
⚠️ Mono built from source

monojenkins · 2019-11-01T20:23:50Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
Failed to build src/
Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

baulig · 2019-11-01T21:02:12Z

build

monojenkins · 2019-11-01T23:10:36Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
Failed to build src/
Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

baulig · 2019-11-04T19:28:33Z

build

monojenkins · 2019-11-04T20:30:08Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
Failed to build src/
Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

rolfbjarne · 2019-11-05T10:15:33Z

build

monojenkins · 2019-11-05T15:15:46Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'

xamarin-release-manager · 2019-11-05T15:50:31Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Packaging' 🔥 : hudson.AbortException: script returned exit code 2

✅ Build succeeded
⚠️ Mono built from source

monojenkins · 2019-11-05T17:13:36Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
⚠️ Mono built from source
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'

xamarin-release-manager · 2019-11-05T17:50:08Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Packaging' 🔥 : hudson.AbortException: script returned exit code 2

✅ Build succeeded
⚠️ Mono built from source

monojenkins · 2019-11-05T22:40:10Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

2 tests failed, 886 tests' device not found, 161 tests passed.

Failed tests

monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
mmptest/macOS/Debug: Failed (Execution failed with exit code 1)

rolfbjarne · 2019-11-06T07:52:45Z

Packaging fails due to https://github.com/xamarin/maccore/issues/2053.

@mandel-macaque could you have a look?

mandel-macaque · 2019-11-06T15:42:30Z

Merging, and I'll fix the pkg issue in a diff PR.

monojenkins · 2019-11-06T15:42:50Z

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
🔥 Build failed 🔥

xamarin-release-manager · 2019-11-06T15:43:22Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2

✅ Provisioning succeeded
🔥 Build failed 🔥

## Miscellaneous fixes * Fixed `/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/builds/mono-ios-sdk-destdir/ios-sources/external/linker/src/linker/Linker.Steps/OutputStep.cs(110,15): error CS0246: The type or namespace name ‘OutputException’ could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tools/mmp/mmp.csproj]` * Changed the name of the method that is used from linker. Because of this commit dotnet/linker@6be2677 * Added `OutputException.cs` file on `mtouch.csproj`. * Removing enter_gc_safe and exit_gc_safe because now it's already gc_safe in this part of code, after a mono change. * Added known exceptions to LLVM exception list. * Needs `ifdef` because of this mono/mono#17260. * Bump MIN_MONO_VERSION to 6.8.0.41 and point MIN_MONO_URL to the PR. * Add ENABLE_IOS=1 and ENABLE_MAC=1. * Added switch to disable packaged mono build * [Tests] Ignore tests that fail on 32b. Ignore the test on 32b, and filled issue: mono/mono#17752 * [Tests] Ignore a couple of tests causing OOM. Hopefully fixes xamarin/maccore#1659 for good. * Ignore `MM0135` test on Catalina+ because it needs Xcode 9.4. * [monotouch-test] Add null checks for teardown when test didn't run because of a too early OS version. * [CFNetwork]: Http 2.0 requires OS X 10.11 or later. Check whether `_HTTPVersion2_0` is available and fallback to HTTP 1.1 otherwise. ## Bring HttpClient from CoreFX * #7346 * This bumps Mono to use mono/mono#17645 (which is the 2019-10 backport of mono/mono#17628). * The big user-visible change is in regards to certificate validation, everything below are just some minor adjustments to tests. ### SocketsHttpHandler CoreFX uses a completely new `HttpClientHandler` implementation called `SocketsHttpHandler`, which you can find at https://github.com/dotnet/corefx/tree/release/3.0/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler. Since this is not based on the web stack anymore, it does not use any of the related APIs such as `ServicePointManager` or `WebException`. ### Certificate Validation Changes There is a new API called `HttpClientHandler.ServerCertificateCustomValidationCallback`. - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.servercertificatecustomvalidationcallback?view=netframework-4.8 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Unix.cs#L154 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Windows.cs#L383 The `ServicePointManager.ServerCertificateValidationCallback` is no longer invoked and on certificate validation failure, `AuthenticationException` (from `System.Security.Authentication`) is thrown instead of `WebException`. At the moment, the `NSUrlSessionHandler` still uses it's own validation callback and also still throws `WebException` on failure; we should probably look into making this consistent with the other handlers. ### Minor adjustments related to internal Mono APIs * `HttpContent.SerializeToStreamAsync()` is now `protected` (changed from `protected internal`). - src/Foundation/NSUrlSessionHandler.cs: changed overload accordingly. - src/System.Net.Http/CFContentStream.cs: likewise. * `HttpHeaders.GetKnownHeaderKind()` is an internal Mono API. There is a new internal API called `System.Net.Http.PlatformHelper.IsContentHeader(key)` which exists in both the old as well as the new implementation. The correct way of doing it with the CoreFX handler is `HeaderDescriptor.TryGet (key, out var descriptor) && descriptor.HeaderType == HttpHeaderType.Content` ### Minor adjustments to tests. * `HttpClientHandler.MaxRequestContentBufferSize` is now longer supported, you can set it to any non-negative value, the getter will always return 0. See https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Core.cs#L18. - tests/linker/ios/link sdk/HttpClientHandlerTest.cs: removed assertion from test. * `HttpMessageInvoker.handler` is a `protected private` field - in the CoreFX handler, it is called `_handler` and `private`. This is accessed via reflection by some of the tests, which are now using the new name. - tests/mmptest/src/MMPTest.cs: here - tests/mtouch/MTouch.cs: here * tests/monotouch-test/System.Net.Http/MessageHandlers.cs: Adjust `RejectSslCertificatesServicePointManager` to reflect the certificate validation changes described above. - FIXME: There was an `Assert.Ignore()` related to `NSUrlSessionHandler` and macOS 10.10; I removed that to reenable the test because the description linked to an old issue in the private repo that was referenced by several "Merged" PR's, so it looked to me that this might have already been fixed - and I also didn't see why it would fail there.

* Fixed `/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/builds/mono-ios-sdk-destdir/ios-sources/external/linker/src/linker/Linker.Steps/OutputStep.cs(110,15): error CS0246: The type or namespace name ‘OutputException’ could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tools/mmp/mmp.csproj]` * Changed the name of the method that is used from linker. Because of this commit dotnet/linker@6be2677 * Added `OutputException.cs` file on `mtouch.csproj`. * Removing enter_gc_safe and exit_gc_safe because now it's already gc_safe in this part of code, after a mono change. * Added known exceptions to LLVM exception list. * Needs `ifdef` because of this mono/mono#17260. * Bump MIN_MONO_VERSION to 6.8.0.41 and point MIN_MONO_URL to the PR. * Add ENABLE_IOS=1 and ENABLE_MAC=1. * Added switch to disable packaged mono build * [Tests] Ignore tests that fail on 32b. Ignore the test on 32b, and filled issue: mono/mono#17752 * [Tests] Ignore a couple of tests causing OOM. Hopefully fixes xamarin/maccore#1659 for good. * Ignore `MM0135` test on Catalina+ because it needs Xcode 9.4. * [monotouch-test] Add null checks for teardown when test didn't run because of a too early OS version. * [CFNetwork]: Http 2.0 requires OS X 10.11 or later. Check whether `_HTTPVersion2_0` is available and fallback to HTTP 1.1 otherwise. * xamarin#7346 * This bumps Mono to use mono/mono#17645 (which is the 2019-10 backport of mono/mono#17628). * The big user-visible change is in regards to certificate validation, everything below are just some minor adjustments to tests. CoreFX uses a completely new `HttpClientHandler` implementation called `SocketsHttpHandler`, which you can find at https://github.com/dotnet/corefx/tree/release/3.0/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler. Since this is not based on the web stack anymore, it does not use any of the related APIs such as `ServicePointManager` or `WebException`. There is a new API called `HttpClientHandler.ServerCertificateCustomValidationCallback`. - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.servercertificatecustomvalidationcallback?view=netframework-4.8 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Unix.cs#L154 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Windows.cs#L383 The `ServicePointManager.ServerCertificateValidationCallback` is no longer invoked and on certificate validation failure, `AuthenticationException` (from `System.Security.Authentication`) is thrown instead of `WebException`. At the moment, the `NSUrlSessionHandler` still uses it's own validation callback and also still throws `WebException` on failure; we should probably look into making this consistent with the other handlers. * `HttpContent.SerializeToStreamAsync()` is now `protected` (changed from `protected internal`). - src/Foundation/NSUrlSessionHandler.cs: changed overload accordingly. - src/System.Net.Http/CFContentStream.cs: likewise. * `HttpHeaders.GetKnownHeaderKind()` is an internal Mono API. There is a new internal API called `System.Net.Http.PlatformHelper.IsContentHeader(key)` which exists in both the old as well as the new implementation. The correct way of doing it with the CoreFX handler is `HeaderDescriptor.TryGet (key, out var descriptor) && descriptor.HeaderType == HttpHeaderType.Content` * `HttpClientHandler.MaxRequestContentBufferSize` is now longer supported, you can set it to any non-negative value, the getter will always return 0. See https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Core.cs#L18. - tests/linker/ios/link sdk/HttpClientHandlerTest.cs: removed assertion from test. * `HttpMessageInvoker.handler` is a `protected private` field - in the CoreFX handler, it is called `_handler` and `private`. This is accessed via reflection by some of the tests, which are now using the new name. - tests/mmptest/src/MMPTest.cs: here - tests/mtouch/MTouch.cs: here * tests/monotouch-test/System.Net.Http/MessageHandlers.cs: Adjust `RejectSslCertificatesServicePointManager` to reflect the certificate validation changes described above. - FIXME: There was an `Assert.Ignore()` related to `NSUrlSessionHandler` and macOS 10.10; I removed that to reenable the test because the description linked to an old issue in the private repo that was referenced by several "Merged" PR's, so it looked to me that this might have already been fixed - and I also didn't see why it would fail there.

* Fixed `/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/builds/mono-ios-sdk-destdir/ios-sources/external/linker/src/linker/Linker.Steps/OutputStep.cs(110,15): error CS0246: The type or namespace name ‘OutputException’ could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tools/mmp/mmp.csproj]` * Changed the name of the method that is used from linker. Because of this commit dotnet/linker@6be2677 * Added `OutputException.cs` file on `mtouch.csproj`. * Removing enter_gc_safe and exit_gc_safe because now it's already gc_safe in this part of code, after a mono change. * Added known exceptions to LLVM exception list. * Needs `ifdef` because of this mono/mono#17260. * Bump MIN_MONO_VERSION to 6.8.0.41 and point MIN_MONO_URL to the PR. * Add ENABLE_IOS=1 and ENABLE_MAC=1. * Added switch to disable packaged mono build * [Tests] Ignore tests that fail on 32b. Ignore the test on 32b, and filled issue: mono/mono#17752 * [Tests] Ignore a couple of tests causing OOM. Hopefully fixes xamarin/maccore#1659 for good. * Ignore `MM0135` test on Catalina+ because it needs Xcode 9.4. * [monotouch-test] Add null checks for teardown when test didn't run because of a too early OS version. * [CFNetwork]: Http 2.0 requires OS X 10.11 or later. Check whether `_HTTPVersion2_0` is available and fallback to HTTP 1.1 otherwise. * #7346 * This bumps Mono to use mono/mono#17645 (which is the 2019-10 backport of mono/mono#17628). * The big user-visible change is in regards to certificate validation, everything below are just some minor adjustments to tests. CoreFX uses a completely new `HttpClientHandler` implementation called `SocketsHttpHandler`, which you can find at https://github.com/dotnet/corefx/tree/release/3.0/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler. Since this is not based on the web stack anymore, it does not use any of the related APIs such as `ServicePointManager` or `WebException`. There is a new API called `HttpClientHandler.ServerCertificateCustomValidationCallback`. - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.servercertificatecustomvalidationcallback?view=netframework-4.8 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Unix.cs#L154 - https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Windows.cs#L383 The `ServicePointManager.ServerCertificateValidationCallback` is no longer invoked and on certificate validation failure, `AuthenticationException` (from `System.Security.Authentication`) is thrown instead of `WebException`. At the moment, the `NSUrlSessionHandler` still uses it's own validation callback and also still throws `WebException` on failure; we should probably look into making this consistent with the other handlers. * `HttpContent.SerializeToStreamAsync()` is now `protected` (changed from `protected internal`). - src/Foundation/NSUrlSessionHandler.cs: changed overload accordingly. - src/System.Net.Http/CFContentStream.cs: likewise. * `HttpHeaders.GetKnownHeaderKind()` is an internal Mono API. There is a new internal API called `System.Net.Http.PlatformHelper.IsContentHeader(key)` which exists in both the old as well as the new implementation. The correct way of doing it with the CoreFX handler is `HeaderDescriptor.TryGet (key, out var descriptor) && descriptor.HeaderType == HttpHeaderType.Content` * `HttpClientHandler.MaxRequestContentBufferSize` is now longer supported, you can set it to any non-negative value, the getter will always return 0. See https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Core.cs#L18. - tests/linker/ios/link sdk/HttpClientHandlerTest.cs: removed assertion from test. * `HttpMessageInvoker.handler` is a `protected private` field - in the CoreFX handler, it is called `_handler` and `private`. This is accessed via reflection by some of the tests, which are now using the new name. - tests/mmptest/src/MMPTest.cs: here - tests/mtouch/MTouch.cs: here * tests/monotouch-test/System.Net.Http/MessageHandlers.cs: Adjust `RejectSslCertificatesServicePointManager` to reflect the certificate validation changes described above. - FIXME: There was an `Assert.Ignore()` related to `NSUrlSessionHandler` and macOS 10.10; I removed that to reenable the test because the description linked to an old issue in the private repo that was referenced by several "Merged" PR's, so it looked to me that this might have already been fixed - and I also didn't see why it would fail there.

baulig requested review from spouliot, mandel-macaque, steveisok and chamons October 31, 2019 17:38

baulig self-assigned this Oct 31, 2019

VincentDondain reviewed Nov 1, 2019

View reviewed changes

baulig marked this pull request as ready for review November 1, 2019 18:51

baulig requested a review from rolfbjarne as a code owner November 1, 2019 18:51

baulig added the disable-packaged-mono Build Mono from source instead of using the Mono SDK archive label Nov 1, 2019

Bump MIN_MONO_VERSION to 6.8.0.41 and point MIN_MONO_URL to the PR.

a2c00dd

baulig added build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. and removed disable-packaged-mono Build Mono from source instead of using the Mono SDK archive labels Nov 1, 2019

Add ENABLE_IOS=1 and ENABLE_MAC=1.

80512c4

baulig added run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. labels Nov 1, 2019

rolfbjarne added the skip-api-comparison Skips API / generator diffs when testing pull requests label Nov 5, 2019

Added switch to disable packaged mono build

065afaa

Merge branch 'mono-2019-10' into work-httpclient-2019-10

5dc730f

rolfbjarne added the skip-device-tests Skip device tests label Nov 6, 2019

rolfbjarne mentioned this pull request Nov 6, 2019

Bump to mono:2019-10 #7192

Merged

Merge branch 'mono-2019-10' into work-httpclient-2019-10

f874778

mandel-macaque merged commit 7cbfa3a into mono-2019-10 Nov 6, 2019

VincentDondain mentioned this pull request Dec 5, 2019

[backport] Bump to mono:2019-10 (#7192) #7547

Merged

branchseer mentioned this pull request Jan 18, 2020

[Meta] .NET 5 Support #7528

Closed

mandel-macaque deleted the work-httpclient-2019-10 branch May 21, 2020 04:06

rolfbjarne added the note-highlight Worth calling out specifically in release notes label Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring HttpClient from CoreFX. #7346

Bring HttpClient from CoreFX. #7346

baulig commented Oct 31, 2019

monojenkins commented Oct 31, 2019

spouliot commented Oct 31, 2019

filipnavara commented Oct 31, 2019

spouliot commented Nov 1, 2019

filipnavara commented Nov 1, 2019

VincentDondain left a comment

mandel-macaque commented Nov 1, 2019

baulig commented Nov 1, 2019

monojenkins commented Nov 1, 2019

monojenkins commented Nov 1, 2019

xamarin-release-manager commented Nov 1, 2019

xamarin-release-manager commented Nov 1, 2019

monojenkins commented Nov 1, 2019

baulig commented Nov 1, 2019

monojenkins commented Nov 1, 2019

baulig commented Nov 4, 2019

monojenkins commented Nov 4, 2019

rolfbjarne commented Nov 5, 2019

monojenkins commented Nov 5, 2019

xamarin-release-manager commented Nov 5, 2019

monojenkins commented Nov 5, 2019

xamarin-release-manager commented Nov 5, 2019

monojenkins commented Nov 5, 2019

Failed tests

rolfbjarne commented Nov 6, 2019

mandel-macaque commented Nov 6, 2019

monojenkins commented Nov 6, 2019

xamarin-release-manager commented Nov 6, 2019

Bring HttpClient from CoreFX. #7346

Bring HttpClient from CoreFX. #7346

Conversation

baulig commented Oct 31, 2019

SocketsHttpHandler

Certificate Validation Changes

Minor adjustments related to internal Mono APIs

Minor adjustments to tests.

monojenkins commented Oct 31, 2019

spouliot commented Oct 31, 2019

filipnavara commented Oct 31, 2019

spouliot commented Nov 1, 2019

filipnavara commented Nov 1, 2019

VincentDondain left a comment

Choose a reason for hiding this comment

mandel-macaque commented Nov 1, 2019

baulig commented Nov 1, 2019

monojenkins commented Nov 1, 2019

monojenkins commented Nov 1, 2019

xamarin-release-manager commented Nov 1, 2019

xamarin-release-manager commented Nov 1, 2019

monojenkins commented Nov 1, 2019

baulig commented Nov 1, 2019

monojenkins commented Nov 1, 2019

baulig commented Nov 4, 2019

monojenkins commented Nov 4, 2019

rolfbjarne commented Nov 5, 2019

monojenkins commented Nov 5, 2019

xamarin-release-manager commented Nov 5, 2019

monojenkins commented Nov 5, 2019

xamarin-release-manager commented Nov 5, 2019

monojenkins commented Nov 5, 2019

Test results

Failed tests

rolfbjarne commented Nov 6, 2019

mandel-macaque commented Nov 6, 2019

monojenkins commented Nov 6, 2019

xamarin-release-manager commented Nov 6, 2019