Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d16-3] [Generator] NSValueReturnMap is registering CATransform3D on HaveCoreMedia insteand of HaveCoreAnimation. #6523

Merged
merged 1 commit into from
Jul 8, 2019
Merged

[d16-3] [Generator] NSValueReturnMap is registering CATransform3D on HaveCoreMedia insteand of HaveCoreAnimation. #6523

merged 1 commit into from
Jul 8, 2019

Conversation

monojenkins
Copy link
Collaborator

The CATransform3D is present in the CoreAnimation framework not
CoreMedia.

Fixes #6518

Backport of #6519.

/cc @mandel-macaque

@mandel-macaque @monojenkins
[Generator] NSValueReturnMap is registering CATransform3D on HaveCore…
fdb759d 
…Media insteand of HaveCoreAnimation.

The CATransform3D is present in the CoreAnimation framework not
CoreMedia.

Fixes xamarin#6518
@monojenkins monojenkins added this to the d16-3 milestone Jul 8, 2019
@monojenkins
Copy link
Collaborator Author

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 4abe39b
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
✅ Test run succeeded

@mandel-macaque
Copy link
Member

API diff issues can be ignored.

@mandel-macaque mandel-macaque merged commit 775cedf into xamarin:d16-3 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot Awaiting requested review from spouliot

@VincentDondain VincentDondain Awaiting requested review from VincentDondain VincentDondain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
d16-3
Development

Successfully merging this pull request may close these issues.
4 participants
@monojenkins @mandel-macaque @dalexsoto @rolfbjarne