Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Improve diagnostics/behavior in case of failure to contact the IDE when debugging. #5029

Merged
merged 1 commit into from
Oct 24, 2018

Commits on Oct 23, 2018

  1. [runtime] Improve diagnostics/behavior in case of failure to contact …

    …the IDE when debugging.
    
    When debugging watchOS apps on device, we wait forever [1] for a connection to
    be established to the IDE (iOS apps wait for only 2 seconds, but that's
    because the app will be killed after a while, which we avoid on watchOS by
    attaching the native debugger).
    
    Unfortunately our error handling was not quite optimal, which meant that if
    the connection to the IDE failed, we'd wait forever instead of launching the
    app without attaching the debugger.
    
    So improve this, by printing "Waiting for connection to the IDE..." messages
    while trying to connect, and printing detailed log messages if the
    connection attempt fails (as well as terminating the wait and launching the
    watch app).
    
    [1] In this case forever technically means "1 hour".
    rolfbjarne committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    b2cbeac View commit details
    Browse the repository at this point in the history