Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d15-9] Order additional arguments after response file (#4607) #4612

Merged
merged 1 commit into from
Aug 14, 2018
Merged

[d15-9] Order additional arguments after response file (#4607) #4612

merged 1 commit into from
Aug 14, 2018

Conversation

chamons
Copy link
Contributor

@chamons chamons commented Aug 13, 2018

@chamons
Order additional arguments after response file (xamarin#4607)
33a2f34 
- xamarin#4594
- There were being adding _before_ the response file which meant options that were overriding defaults were not being honored
@chamons chamons requested a review from spouliot August 13, 2018 18:11
@chamons chamons changed the title Order additional arguments after response file (#4607) [d15-9] Order additional arguments after response file (#4607) Aug 13, 2018
@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
✅ Test run succeeded

@spouliot spouliot added this to the d15-9 milestone Aug 14, 2018
@spouliot spouliot merged commit 1db1985 into xamarin:d15-9 Aug 14, 2018
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Sep 6, 2018
@chamons
Order additional arguments after response file (xamarin#4607) (xamari…
2a3d5ae 
…n#4612)

- xamarin#4594
- There were being adding _before_ the response file which meant options that were overriding defaults were not being honored
spouliot added a commit that referenced this pull request Sep 7, 2018
@spouliot
Order additional arguments after response file (#4607) (#4612) (#4769)
ce207d2 
- #4594
- There were being adding _before_ the response file which meant options that were overriding defaults were not being honored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@emaf emaf emaf approved these changes

@jstedfast jstedfast Awaiting requested review from jstedfast jstedfast is a code owner

@kzu kzu Awaiting requested review from kzu

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

@VincentDondain VincentDondain Awaiting requested review from VincentDondain VincentDondain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
d15-9
Development

Successfully merging this pull request may close these issues.
4 participants
@chamons @monojenkins @spouliot @emaf