[MMP] Allow resolving assemblies to the ones passed in command line a… #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgs (xamarin#3575) * [MMP] Revert recursive search dirs changes * [MMP] Allow resolving assemblies to the ones passed in command line args This is what actually makes the MonoMacResolver actually resolve to assemblies given as arguments. This mirrors the behaviour of Pack, which is called on the other code-path (that's not --runregistrar) https://github.com/xamarin/xamarin-macios/blob/3113c5d2b5cca730372177e9b1cee17062a959ff/tools/mmp/driver.cs#L513
|
build |
spouliot
approved these changes
Mar 2, 2018
|
Build failure |
1 similar comment
|
Build failure |
rolfbjarne
approved these changes
Mar 5, 2018
|
Looks to be a random failure (filed) - https://github.com/xamarin/maccore/issues/662 Re-running to be careful, it is d15-7 branch. |
|
build |
|
Build failure |
|
Failures known - https://github.com/xamarin/maccore/issues/658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rgs (#3575)
This is what actually makes the MonoMacResolver actually resolve to
assemblies given as arguments.
This mirrors the behaviour of Pack, which is called on the other
code-path (that's not --runregistrar)
xamarin-macios/tools/mmp/driver.cs
Line 513 in 3113c5d
This is a cherry pick of #3575 to d15-7