Fix macOS 10.13 test failures #3066
Conversation
|
Build failure |
| @@ -692,9 +692,6 @@ | |||
| <Compile Include="..\monotouch-test\ObjCRuntime\RegistrarTest.cs"> | |||
| <Link>ObjCRuntime\RegistrarTest.cs</Link> | |||
| </Compile> | |||
| <Compile Include="..\api-shared\ObjCRuntime\Registrar.cs"> | |||
There was a problem hiding this comment.
This doesn't look quite right...
There was a problem hiding this comment.
When I built the csproj (to run the tests) in XS I got an error about duplicate files. Let me revert this here and PR it separate if I see it again.
There was a problem hiding this comment.
I just reverted this and I get this locally:
/Library/Frameworks/Mono.framework/Versions/5.4.1/lib/mono/msbuild/15.0/bin/Roslyn/Microsoft.CSharp.Core.targets(84,5): error MSB3105: The item "../api-shared/ObjCRuntime/Registrar.cs" was specified more than once in the "Sources" parameter. Duplicate items are not supported by the "Sources" parameter. [/Users/donblas/Programming/macios/xcode9/xamarin-macios/tests/xammac_tests/xammac_tests.csproj]
doing more digging.
There was a problem hiding this comment.
<Compile Include="..\api-shared\ObjCRuntime\Registrar.cs">
<Link>Registrar.cs</Link>
</Compile>
<Compile Include="..\monotouch-test\ObjCRuntime\RegistrarTest.cs">
<Link>ObjCRuntime\RegistrarTest.cs</Link>
</Compile>
<Compile Include="..\api-shared\ObjCRuntime\Registrar.cs">
<Link>api-shared\ObjCRuntime\Registrar.cs</Link>
</Compile>
It is duplicated... Why did this not fail before?
There was a problem hiding this comment.
@rolfbjarne This "works" because we use xbuild to build the tests on the bots. I used msbuild to compile time check and it fails there.
Another xbuild/msbuild ism...
There was a problem hiding this comment.
It's not duplicated here: https://github.com/chamons/xamarin-macios/blob/b520a737f3c33fc6baf836ef4921fb5e81eb1683/tests/xammac_tests/xammac_tests.csproj#L689-L697
Local changes?
There was a problem hiding this comment.
Actually nvm, of course it won't show duplicated items when I'm looking at the commit where you fixed it.
In the xcode9.2 branch it is duplicated:
xamarin-macios/tests/xammac_tests/xammac_tests.csproj
Lines 689 to 697 in 2bfbc8a
| @@ -114,20 +114,19 @@ public void RoundtripRSAMinPKCS1 () | |||
| byte [] cipher; | |||
| if (TestRuntime.CheckXcodeVersion (8,0)) { | |||
| Assert.True (public_key.IsAlgorithmSupported (SecKeyOperationType.Encrypt, SecKeyAlgorithm.RsaEncryptionPkcs1), "public/IsAlgorithmSupported/Encrypt"); | |||
| #if MONOMAC | |||
| Assert.False (public_key.IsAlgorithmSupported (SecKeyOperationType.Decrypt, SecKeyAlgorithm.RsaEncryptionPkcs1), "public/IsAlgorithmSupported/Decrypt"); | |||
| Action decryptTest = v => { | |||
There was a problem hiding this comment.
/Users/poupou/git/xcode9.2/xamarin-macios/tests/monotouch-test/Security/KeyTest.cs(117,27): error CS1593: Delegate 'Action' does not take 1 arguments
/Users/poupou/git/xcode9.2/xamarin-macios/tests/monotouch-test/Security/KeyTest.cs(127,19): error CS0103: The name 'Mac' does not exist in the current context
/Users/poupou/git/xcode9.2/xamarin-macios/tests/monotouch-test/Security/KeyTest.cs(216,133): error CS0103: The name 'Mac' does not exist in the current context
weird it fails to build locally when I do a make run-mac-xammac_tests on xcode9.2 branch
There was a problem hiding this comment.
Not that weird, it failed on bots too (checked the wrong PR result, too many windows)
There was a problem hiding this comment.
I blind pushed this (mentioned on #mac) due to build issues locally end of day. I thought I compiled it though, my mistake.
|
Build success |
|
@spouliot 👍 ? |
|
@spouliot The csproj change fixed my local build. I have had some trouble reproducing these changes locally, but the tests run successfully for me and I figured the bots can be the final arbitrator. |
|
@chamons jenkins bots are on 10.12 - I rather know if it's fine before merging and wrench to validate on high-sierra |
No description provided.