-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct namespace for async debugging helpers. Fixes #59015 #2704
Conversation
Build failure |
This should include the get_ObjectIdForDebugger () method as well. |
Build failure |
1 similar comment
Build failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some unit tests this time as this is a regression of https://bugzilla.xamarin.com/show_bug.cgi?id=55037
Its not a regression, the problem happens on android now. |
@vargaz "[iOS]error: * Assertion at /Users/builder/data/lanes/4691/6bea7a5b/source/xamarin-macios/external/mono/mono/mini/debugger-agent.c:4712, condition `array->len == 1' not met while debugging async methods" from VERIFIED/FIXED from https://bugzilla.xamarin.com/show_bug.cgi?id=55037 sounds very close to "2017-08-24 17:01:29.365 sampleSIGABRT.iOS[1952:392599] error: * Assertion at /Users/builder/data/lanes/5143/80f17b0b/source/xamarin-macios/external/mono/mono/mini/debugger-agent.c:4714, condition `array->len == 1' not met" from https://bugzilla.xamarin.com/show_bug.cgi?id=59015 even if it seems (from the code) that it was never really fixed (but it did went thru all the process steps) |
Replace xamarin#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] xamarin#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
PR #2782 does the same but adds unit tests |
…015 (#2782) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
…015 (xamarin#2782) Replace xamarin#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] xamarin#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
…015 (#2782) (#2788) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
No description provided.