[XM] Fix dontlink by fixing some NSAccessibility binding mistakes #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22049,7 +22049,7 @@ partial interface NSAccessibilityAttributes { | |||
| [Field ("NSAccessibilityDisclosedRowsAttribute")] | |||
| NSString DisclosedRowsAttribute { get; } | |||
|
|
|||
| [Field ("NSAccessibilityDisclosedByRowsAttribute")] | |||
| [Field ("NSAccessibilityDisclosedByRowAttribute")] | |||
| NSString DisclosedByRowsAttribute { get; } | |||
There was a problem hiding this comment.
Managed name should be fixed too (extra s)
|
IIRC you can just create an interface without any attribute and have it inlined (or I dreamt that feature). |
|
@spouliot I could have sworn I tried that, but testing suggests I didn't. Let me rework... |
|
Build success |
|
LGTM if dontlink-mac is happy :) |
|
Build success |
1 similar comment
|
Build success |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was not run against dontlink and sadness occurred: f535df6
This fixes things up.
I did not want to expose the previously named NSObjectAccessibilityExtensions on NSObject, even if that's what the header says, since that will really dirty up auto complete. Oh and:
BOOL oDoes = [o respondsToSelector:@selector(accessibilityHitTest:)]; // NSObject * o - NO
BOOL vDoes = [v respondsToSelector:@selector(accessibilityHitTest:)]; // NSView * v - YES
So I did a copy/paste. Which is terrible. Not sure a better way (open to suggestions).