Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Pass the right arguments to the AOT compiler for Mac Catalyst. Fixes #12484. #12498

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

rolfbjarne
Copy link
Member

Mac Catalyst is just special.

Also add an xharness test variation and update a test amkefile.

Fixes #12484.

@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Aug 20, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 146 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2469 Passed: 2394 Inconclusive: 13 Failed: 2 Ignored: 73)
  • monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: Failed (Test run failed.
    Tests run: 2466 Passed: 2391 Inconclusive: 11 Failed: 5 Ignored: 70)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2480 Inconclusive: 35 Failed: 10 Ignored: 148)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 47edf6d into 2d4b68b

@rolfbjarne
Copy link
Member Author

Test failures are unrelated, all fixed by #12509.

@rolfbjarne rolfbjarne merged commit e3cac56 into dotnet:main Aug 23, 2021
@rolfbjarne rolfbjarne deleted the llvm-maccatalyst branch August 23, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6: LLVM AOT doesn't work on MacCatalyst
3 participants