Bump .NET to 6.0.100-preview.2.21114.3. #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom linker steps.
…efore the new first step (MarkStep).
… make it load every assembly.
…g .NET supports for now.
spouliot
reviewed
Feb 18, 2021
| protected override void TryEndProcess () | ||
| { | ||
| foreach (var asm in Configuration.Assemblies) | ||
| System.Console.WriteLine ($"Collected assembly: {asm.FullName}"); |
There was a problem hiding this comment.
no need for System. prefix
should be under a verbosity check
spouliot
reviewed
Feb 18, 2021
| foreach (var asm in Configuration.ManagedAssembliesToLink) { | ||
| var ad = (AssemblyDefinition) tryResolve.Invoke (Configuration.Context, new object [] { Path.GetFileNameWithoutExtension (asm) }); | ||
| if (ad != null) { | ||
| Console.WriteLine ($"Loaded {asm} => {ad.FullName} => {ad.MainModule.FileName}"); |
There was a problem hiding this comment.
should be under a verbosity check
spouliot
reviewed
Feb 18, 2021
| if (ad != null) { | ||
| Console.WriteLine ($"Loaded {asm} => {ad.FullName} => {ad.MainModule.FileName}"); | ||
| } else { | ||
| Console.WriteLine ($"Failed to load {asm}"); |
There was a problem hiding this comment.
should be reported as an error ? or warning
mandel-macaque
approved these changes
Feb 18, 2021
…do load assemblies in custom step.
… to the custom linker steps." This reverts commit eae95d8. We don't need it anymore.
dalexsoto
approved these changes
Feb 18, 2021
❌ Tests failed on Build ❌Tests failed on Build. Test results44 tests failed, 2 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099' |
|
bad bot |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. Test results4 tests failed, 177 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099' |
…ew log version.
Otherwise this happens in tests that read binary logs:
System.NotSupportedException : Unsupported log file format. Latest supported version is 9, the log file has version 10.
spouliot
approved these changes
Feb 19, 2021
tj-devel709
approved these changes
Feb 19, 2021
❌ Tests failed on Build ❌Tests failed on Build. Test results1 tests failed, 180 tests passed.Failed tests
Pipeline on Agent XAMBOT-1103' |
…mory as a temporary solution for mono's removal of the same method.
emaf
approved these changes
Feb 22, 2021
✅ Tests passed on Build. ✅Tests passed on Build. 🎉 All 181 tests passed 🎉Pipeline on Agent XAMBOT-1094' |
✅ Tests passed on Build. ✅Tests passed on Build. 🎉 All 181 tests passed 🎉Pipeline on Agent XAMBOT-1095' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a few other changes, because the linker changed significantly.
This is still a draft because some of the changes here aren't final (and there's some debug spew as well), I just want a CI run to find everything that breaks.