Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[generator] Fix BI0000 from FormatException when no arguments are pro…
…vided for an error (#7078) Add new overloads so we can skip `String.Format` calls when relaying messages without any arguments. Solve cases like ``` error BI0000: Unexpected error - Please file a bug report at https://github.com/xamarin/xamarin-macios/issues/new System.FormatException: Input string was not in a correct format. at System.Text.StringBuilder.AppendFormatHelper (System.IFormatProvider provider, System.String format, System.ParamsArray args) [0x000b2] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-06/external/bockbuild/builds/mono-x64/external/corefx/src/Common/src/CoreLib/System/Text/StringBuilder.cs:1445 ... ``` because we failed compilation due to an (hidden) syntax error like: ``` foundation.cs(3627,3): error CS1519: Invalid token '{' in class, struct, or interface member declaration ``` where the `{` character is causing the `FormatException` inside the generator sources. This is now more properly reported as ``` error BI0002: bgen: Could not compile the API bindings. foundation.cs(3627,3): error CS1519: Invalid token '{' in class, struct, or interface member declaration ```
- Loading branch information
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥
Test results
5 tests failed, 108 tests passed.
Failed tests
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Jenkins job (on internal Jenkins) succeeded
✅ Build succeeded
✅ Packages:
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥
✅ Build succeeded
✅ Packages:
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥
Test results
1 tests failed, 162 tests passed.
Failed tests
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥
Test results
3 tests failed, 110 tests passed.
Failed tests
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥
Test results
11 tests failed, 102 tests passed.
Failed tests
80e6e63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Canceled) on iOS32b on Azure DevOps(iOS32b): Html Report 🔥
🔥 Tests failed catastrophically on iOS32b (no summary found)