Skip to content

Commit

Permalink
[Generator] NSValueReturnMap is registering CATransform3D on HaveCore…
Browse files Browse the repository at this point in the history 
…Media insteand of HaveCoreAnimation. (#6523)

The CATransform3D is present in the CoreAnimation framework not
CoreMedia.

Fixes #6518
  • Loading branch information
@monojenkins @mandel-macaque
monojenkins authored and mandel-macaque committed Jul 8, 2019
1 parent 069293c commit 775cedf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/generator.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1477,7 +1477,7 @@ Dictionary<Type,string> NSValueReturnMap {
nsvalue_return_map [TypeManager.CMTimeMapping] = ".CMTimeMappingValue";
}

if (Frameworks.HaveCoreMedia)
if (Frameworks.HaveCoreAnimation)
nsvalue_return_map [TypeManager.CATransform3D] = ".CATransform3DValue";
}
return nsvalue_return_map;
Expand Down

2 comments on commit 775cedf

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥

Test results

34 tests failed, 79 tests passed.

Failed tests

  • framework-test/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • link all/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed (Install failed, exit code: 137.)
  • monotouch-test/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Failed (Install failed, exit code: 137.)
  • monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): Failed (Install failed, exit code: 137.)
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Failed (Install failed, exit code: 137.)
  • framework-test/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • interdependent-binding-projects/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • fsharp/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed (Install failed, exit code: 137.)
  • dont link/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • link all/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed (Install failed, exit code: 137.)
  • link all/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed (Install failed, exit code: 137.)
  • link sdk/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • mono-native-compat/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed (Install failed, exit code: 137.)
  • mono-native-unified/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed (Install failed, exit code: 137.)
  • mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed (Install failed, exit code: 137.)
  • mscorlib/iOS Unified 64-bits - device/Release: Failed (Install failed, exit code: 137.)
  • mscorlib/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed (Install failed, exit code: 137.)
  • [xUnit] Mono BCL tests group 6/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed (Install failed, exit code: 137.)

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.16.0.7.pkg xamarin.mac-5.16.0.7.pkg
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 775cedf
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

1 tests failed, 170 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed

Please sign in to comment.