Skip to content

Commit

Permalink
[xharness] Fix finding testable types in test assemblies. Fixes #xama…
Browse files Browse the repository at this point in the history
…rin/maccore@2267. (#9103)

Apparently a null namespace when using Reflection can be an empty namespace in Cecil.

Fixes xamarin/maccore#2267.
  • Loading branch information
rolfbjarne committed Jul 16, 2020
1 parent 5657a63 commit 7509c6b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public bool Validate ()
if (t.HasGenericParameters)
return false;
if (t.Namespace == null)
if (string.IsNullOrEmpty (t.Namespace))
return false;
if (!t.FullName.EndsWith ("Test", StringComparison.OrdinalIgnoreCase) && !t.FullName.EndsWith ("Tests", StringComparison.OrdinalIgnoreCase))
Expand Down

5 comments on commit 7509c6b

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (Cambridge) 🔥

Not enough free space in the host.

Pipeline on Agent XI-SCARLET-WITCH

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Not enough free space in the host.

Pipeline on Agent XAMTESTMAC10

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) (no summary found). 🔥

Result file /Users/xamarinqa/azdo/_work/8/s\Reports\TestSummary\TestSummary.md not found.

Pipeline on Agent XAMTESTMAC02

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.11', Running XM tests on '10.9'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests)

Provisioning succeeded
Build succeeded
✅ Packages built successfully

View packages

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.11 failed: Xamarin.Mac tests on macOS 10.11 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.9 failed: Xamarin.Mac tests on macOS 10.9 failed (xammac_tests) 🔥
Test run succeeded

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (Cambridge) ❌

Device tests failed on VSTS: device tests tvOS (Cambridge).

Test results

10 tests failed, 140 tests passed.

Failed tests

  • mono-native-compat/tvOS - device/Debug: Failed
  • mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • mono-native-compat/tvOS - device/Release: Failed
  • mono-native-compat/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
  • mono-native-unified/tvOS - device/Debug: Failed
  • mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • mono-native-unified/tvOS - device/Release: Failed
  • mono-native-unified/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed

Pipeline on Agent XAMTESTWIN04

Please sign in to comment.