Skip to content

Commit

Permalink
[xharness] Only run xammac variations if macOS tests are included. (#…
Browse files Browse the repository at this point in the history 
…9729)

This fixes a build error with a xammac test variation that is executed even if
the macOS build is disabled.
  • Loading branch information
@rolfbjarne
rolfbjarne committed Sep 30, 2020
1 parent b111ce0 commit 5c113d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/xharness/Jenkins/TestVariationsFactory.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ IEnumerable<TestData> GetTestData (RunTestTask test)
yield return new TestData { Variation = "Release (all optimizations)", MonoBundlingExtraArgs = "--registrar:static --optimize:all", Debug = false, LinkMode = "Full", Defines = "OPTIMIZEALL"};
break;
case "Debug":
yield return new TestData { Variation = "Debug (all optimizations)", MonoBundlingExtraArgs = "--registrar:static --optimize:all,-remove-uithread-checks", Debug = true, LinkMode = "Full", Defines = "OPTIMIZEALL", Ignored = !jenkins.IncludeAll };
yield return new TestData { Variation = "Debug (all optimizations)", MonoBundlingExtraArgs = "--registrar:static --optimize:all,-remove-uithread-checks", Debug = true, LinkMode = "Full", Defines = "OPTIMIZEALL", Ignored = !(jenkins.IncludeAll && jenkins.IncludeMac) };
break;
}
break;
Expand Down

5 comments on commit 5c113d2

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (Cambridge) 🔥

Not enough free space in the host.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Not enough free space in the host.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Provisioning succeeded
✅ Build succeeded
✅ Packages built successfully

View packages

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 137 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug (all optimizations): TimedOut
  • introspection/iOS Unified 32-bits - simulator/Debug (iOS 10.3): TimedOut

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (Cambridge) ❌

Device tests failed on VSTS: device tests tvOS (Cambridge).

Test results

15 tests failed, 134 tests passed.

Failed tests

  • monotouch-test/tvOS - device/Debug: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • monotouch-test/tvOS - device/Release: Failed
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (release): Failed
  • monotouch-test/tvOS - device/Debug (dynamic registrar): Failed
  • monotouch-test/tvOS - device/Release (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug (all optimizations): Failed
  • monotouch-test/tvOS - device/Debug: SGenConc: Failed
  • monotouch-test/tvOS - device/Debug (interpreter): Failed
  • monotouch-test/tvOS - device/Debug (interpreter -mscorlib): Failed
  • monotouch-test/tvOS - device/Release (interpreter -mscorlib): Failed
  • mono-native-unified/tvOS - device/Release: TimedOut (HE0053: Failed to create a USB tunnel between the ports 63334 (on device) and 63334 (on the mac): USB connect timeout (61), likely because the app failed to launch. Please review device logs and/or crash reports for more information.)

Pipeline on Agent XI-A-Batman

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (DDFun) ❌

Device tests failed on VSTS: device tests tvOS (DDFun).

Test results

17 tests failed, 132 tests passed.

Failed tests

  • monotouch-test/tvOS - device/Debug: BuildFailure
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): BuildFailure
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): BuildFailure
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): BuildFailure
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): BuildFailure
  • monotouch-test/tvOS - device/Release: BuildFailure
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (release): BuildFailure
  • monotouch-test/tvOS - device/Debug (dynamic registrar): BuildFailure
  • monotouch-test/tvOS - device/Release (all optimizations): BuildFailure
  • monotouch-test/tvOS - device/Debug (all optimizations): BuildFailure
  • monotouch-test/tvOS - device/Debug: SGenConc: BuildFailure
  • monotouch-test/tvOS - device/Debug (interpreter): BuildFailure
  • monotouch-test/tvOS - device/Debug (interpreter -mscorlib): BuildFailure
  • monotouch-test/tvOS - device/Release (interpreter -mscorlib): BuildFailure
  • link all/tvOS - device/Debug: Failed
  • link all/tvOS - device/AssemblyBuildTarget: dylib (debug): Failed
  • [xUnit] Mono SystemXunit/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): Crashed Known issue: Tcp Connection Error: Tests are reported as crashes when they succeeded.

Pipeline on Agent XAMTESTMAC18

Please sign in to comment.