Skip to content

Commit

Permalink
[xharness] Resolve relative project references using the referencing …
Browse files Browse the repository at this point in the history
…project's directory. (#9252)

Otherwise it would end up being resolved from the current directory, which is
not dependable.
  • Loading branch information
rolfbjarne committed Jul 31, 2020
1 parent cc06a93 commit 1e6e17c
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ List<string> GetNestedReferenceProjects (string csproj)
var fixPath = referenceProject.Replace ("\\", "/"); // do the replace in case we use win paths
result.Add (fixPath);
// get all possible references
if (!Path.IsPathRooted (fixPath))
fixPath = Path.Combine (Path.GetDirectoryName (csproj), fixPath);
result.AddRange (GetNestedReferenceProjects (fixPath));
}
return result;
Expand Down

9 comments on commit 1e6e17c

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Pipeline scripts tests failed on VSTS: device tests iOS (DDFun) 🔥

The tests of the scripts used in the pepeline failed. The build was cancelled.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Pipeline scripts tests failed on VSTS: device tests tvOS (DDFun) 🔥

The tests of the scripts used in the pepeline failed. The build was cancelled.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (Cambridge) ❌

Device tests failed on VSTS: device tests tvOS (Cambridge).

Test results

150 tests' device not found, 0 tests passed.

Pipeline on Agent XI-MANTIS

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS32b (Cambridge) ❌

Device tests failed on VSTS: device tests iOS32b (Cambridge).

Test results

161 tests' device not found, 0 tests passed.

Pipeline on Agent XI-W-BULBASAUR

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins job (on internal Jenkins) succeeded

Provisioning succeeded
Build succeeded
✅ Packages built successfully

View packages

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS (Cambridge) ❌

Device tests failed on VSTS: device tests iOS (Cambridge).

Test results

17 tests failed, 133 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - device/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • monotouch-test/iOS Unified 64-bits - device/Release: Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed
  • monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Failed
  • monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - device/Debug: SGenConc: Failed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter): Failed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Failed
  • monotouch-test/iOS Unified 64-bits - device/Release (interpreter -mscorlib): Failed
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - device/Debug: Failed (Install failed, exit code: 137.)
  • framework-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed (Install failed, exit code: 137.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed

Pipeline on Agent XI-IRON-MAN

Please sign in to comment.