[Xamarin.Android.Build.Tasks] Emit warnings if using deprecated bindings fallback flags. #8511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
net9-bindings-warnings
branch
from
599d269
to
a110495
Compare
…ings fallback flags.
jpobst
force-pushed
the
net9-bindings-warnings
branch
from
a110495
to
b52749c
Compare
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
|
As these were intended as temporary fallback properties, there are no tests that use them. My opinion is that testing for these warnings is probably not worth it. |
grendello
added a commit
that referenced
this pull request
Nov 30, 2023
* main: Bump to xamarin/android-api-docs@3f64bdd (#8539) [Xamarin.Android.Build.Tasks] Emit XA1038 for deprecated properties (#8511) Rename ThirdPartyNotices.txt to THIRD-PARTY-NOTICES.TXT (#8546)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #6436
Context: #8339
Previously we have added the following temporary "fallback flags" for bindings-related changes:
$(_AndroidUseJavaLegacyResolver)$(_AndroidEmitLegacyInterfaceInvokers)Because the intent is to remove the old, deprecated code, we need to warn users of these flags that they will be removed in a future version of .NET.
Also fix a typo that prevented
$(_AndroidEmitLegacyInterfaceInvokers)from being able to be set.I don't know that it's worth having unit tests for this, locally this produces: