[Xamarin.Android.Build.Tasks] Extract resources with S.I.C.ZipFile. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionic.Zip.dll, as provided by the Unofficial.Ionic.Zip 1.9.1.8 NuGet package, is broken. [It hardcodes `\` as directory separator char][0], which breaks all manner of things, and when we try to extract and unzip embedded resources from assemblies, it fails: Error executing task ResolveLibraryProjectImports: System.ArgumentException: Path is empty at System.IO.Directory.CreateDirectory (System.String path) <0x1a20ca0 + 0x0011c> in <filename unknown>:0 at Ionic.Zip.ZipEntry.InternalExtract (System.String baseDir, System.IO.Stream outstream, System.String password) <0x3af4b78 + 0x002e7> in <filename unknown>:0 I'm not sure *why* "path is empty" -- the callstack isn't very helpful -- but it *is* empty, which means if a project references an assembly which contains e.g. @(AndroidResource), everthing breaks. Fix the `ResolveLibraryProjectImports` task so that instead of using Ionic.Zip.dll to extract embedded resources we instead use System.IO.Compression.ZipFile (in System.IO.Compression.FileSystem.dll, new in .NET 4.5). Note: *Other* uses of Ionic.Zip.dll are similarly suspect but *are not fixed*. Fixing (removing?) Ionic.Zip.dll will be done later. [0]: https://gitter.im/xamarin/xamarin-android?at=572d97caf36daf63798d6033
dellis1972
referenced
this pull request
in dellis1972/xamarin-android
Sep 30, 2016
Add `/app/lib/mandroid` to directory search paths for FlatPak support.
jonpryor
pushed a commit
that referenced
this pull request
Oct 5, 2016
…) (#243) Add `/app/lib/mandroid` to directory search paths for FlatPak support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ionic.Zip.dll, as provided by the Unofficial.Ionic.Zip 1.9.1.8 NuGet
package, is broken. It hardcodes
\as directory separator char,which breaks all manner of things, and when we try to extract and
unzip embedded resources from assemblies, it fails:
I'm not sure why "path is empty" -- the callstack isn't very
helpful -- but it is empty, which means if a project references an
assembly which contains e.g. @(AndroidResource), everthing breaks.
Fix the
ResolveLibraryProjectImportstask so that instead of usingIonic.Zip.dll to extract embedded resources we instead use
System.IO.Compression.ZipFile (in
System.IO.Compression.FileSystem.dll, new in .NET 4.5).
Note: Other uses of Ionic.Zip.dll are similarly suspect but
are not fixed. Fixing (removing?) Ionic.Zip.dll will be done later.