feat(Totara): Adds \totara_program\event\program_assigned event.
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanHalley
changed the title
garemoko
reviewed
Jun 13, 2019
| @@ -17,7 +17,7 @@ | |||
| namespace src\transformer\utils\extensions; | |||
| defined('MOODLE_INTERNAL') || die(); | |||
|
|
|||
| function base(array $config, \stdClass $event, $course) { | |||
| function base(array $config, \stdClass $event, $course=null) { | |||
There was a problem hiding this comment.
I'm curious about the reason for this change.
There was a problem hiding this comment.
I've used base in src/transformer/events/totara_program/program_assigned.php in a context where a course doesn't exist. The course parameter is only required in this function for the jisc data.
In src/transformer/utils/extensions/course_area.php the function course_area (called from jisc util) already has a condition for if the course is null. I expect my change was actually how it was intended to be initially.
There was a problem hiding this comment.
Makes sense thanks for explaining
garemoko
reviewed
Jun 14, 2019
ryasmi
approved these changes
Jun 18, 2019
ryasmi
changed the title
\totara_program\event\program_assigned event.
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is necessary for us to have a mechanism that allows an event to be supported by the plugin but is not supported by the environment it's installed on.
Moodle has a core function that lists all events, our mapping function should only return events that the environment has installed and the plugin supports.
\totara_program\event\program_assignedhas also been added as an example of how Totara events will be implemented.Related Issues
#571
PR Type
Enhancement