feat(cli): use json5 to support writing comment in wxa.config file

WeBankFinTech · Mar 6, 2020 · fd87b7e · fd87b7e
1 parent 09e12f2
commit fd87b7e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/packages/wxa-cli/package-lock.json b/packages/wxa-cli/package-lock.json
diff --git a/packages/wxa-cli/package.json b/packages/wxa-cli/package.json
@@ -61,6 +61,7 @@
     "htmlparser2": "^3.10.1",
     "inquirer": "^6.2.0",
     "js-base64": "^2.4.0",
+    "json5": "^2.1.1",
     "mkdirp": "^0.5.1",
     "node-notifier": "^5.2.1",
     "promise.prototype.finally": "^3.1.0",

diff --git a/packages/wxa-cli/src/compilers/config.js b/packages/wxa-cli/src/compilers/config.js
@@ -1,8 +1,6 @@
 import {readFile} from '../utils';
 import logger from '../helpers/logger';
-import debugPKG from 'debug';
-
-let debug = debugPKG('WXA:ConfigCompiler');
+import json5 from 'json5';
 
 export default class ConfigCompiler {
     parse(filepath, code) {
@@ -12,11 +10,12 @@ export default class ConfigCompiler {
             logger.error(`文件不存在, ${filepath}`);
             return Promise.reject(null);
         }
-        // debug('code, %O', JSON.parse(code));
+
+        let jsonData = json5.parse(code);
 
         return Promise.resolve({
             kind: 'json',
-            json: JSON.parse(code),
+            json: jsonData,
         });
     }
 }
diff --git a/packages/wxa-cli/src/compilers/wxa.js b/packages/wxa-cli/src/compilers/wxa.js
@@ -5,7 +5,6 @@ import logger from '../helpers/logger';
 import DependencyResolver from '../helpers/dependencyResolver';
 import defaultPret from '../const/defaultPret';
 import {parseXML, serializeXML} from './xml';
-import domSerializer from 'dom-serializer';
 
 const SCRIPT_TAG = 'script';
 const CONFIG_TAG = 'config';