Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select autocomplete dropdown breaks with TypeScript v4.7.x #63

Closed
voinik opened this issue Aug 7, 2022 · 4 comments
Closed

Select autocomplete dropdown breaks with TypeScript v4.7.x #63

voinik opened this issue Aug 7, 2022 · 4 comments

Comments

@voinik
Copy link

voinik commented Aug 7, 2022

Issue type:

[ ] Question
[X] Bug report
[ ] Feature request
[ ] Documentation issue

Database system/driver:

[X] Postgres
[ ] MSSQL
[ ] MySQL
[ ] MariaDB
[ ] SQLite3
[ ] Oracle
[ ] Amazon Redshift

typed-knex version:

[ ] latest
[ ] @next
[4.12.0] 0.x.x (or put your version here)

Knex.js version:
2.2.0

Steps to reproduce or a small repository showing the problem:

  1. Type this using any model with more than 1 property in it:
typedKnex.query(User).select('id');
  1. try to add more properties in the select and you'll find the only choices you have in the dropdown are the keys you already have in there, rather than all keys.

I've tested the following versions of TypeScript: 4.4.4, 4.5.4, 4.6.2, 4.6.4. This bug did not appear in these versions. The bug starts appearing in versions 4.7.2 and higher.

@wwwouter
Copy link
Owner

This seems to be fixed in version 4.8.1-rc
I'm waiting for the official 4.8 release before investigating further.

@wwwouter
Copy link
Owner

Should be released tomorrow microsoft/TypeScript#49074

@wwwouter
Copy link
Owner

4.8 is released! Can you check if it works again?

@voinik
Copy link
Author

voinik commented Aug 26, 2022

Great, it works again! Closing this

@voinik voinik closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants