fix(isCapture): guard use of currentTarget #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronhelser
force-pushed
the
current_target_fix
branch
from
f793903
to
ea5eb3b
Compare
currentTarget was undefined, save it's value using state before using in scroll listener.
aronhelser
force-pushed
the
current_target_fix
branch
from
ea5eb3b
to
4f89a2d
Compare
|
@aronhelser ....and it works like a charm!!!! |
|
Good enough for me 😄 |
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentTarget was undefined, save it's value using
state before using in scroll listener.
@alex-shamshurin, @renanborgez does this fix issue #312 for you? I've tried to simplify the fix as much as possible.