Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node parent when calculating offset #195

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Conversation

iamdoron
Copy link
Contributor

Hi,

I added some transforms to the examples as a quick way to see it's working. When calculating the tooltip position, the parent of the node should be taken as an offset, and not the target.

This is not a complete solution, because the node can be within multiple chain-of-parents with transforms (which have to be accumulated), but at least now if the target is inside a parent with transform the tooltip is in the right position.

@wwayne
Copy link
Collaborator

wwayne commented Sep 29, 2016

I think we can't use node to replace the target here, because the logic doesn't make sense. And I can find another test case that makes this out of work... I'm still thinking about it and trying to figure out a more clear logic.

Anyway, thanks for your PR and exploration, I'm closing this.

@wwayne wwayne closed this Sep 29, 2016
@wwayne wwayne reopened this Sep 29, 2016
@wwayne
Copy link
Collaborator

wwayne commented Sep 29, 2016

After spending almost one hour figuring out the logic behind this, the only thing I found is you are right, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants