Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP response headers should be converted to lowercase #12

Closed
petrdvorak opened this issue Nov 23, 2020 · 0 comments · Fixed by #13
Closed

HTTP response headers should be converted to lowercase #12

petrdvorak opened this issue Nov 23, 2020 · 0 comments · Fixed by #13
Assignees
@hvge
Labels
bug Something isn't working

Comments

@petrdvorak
Copy link
Member

Currently, we use code that depends on the X-Cert-Pinning-Signature HTTP header. However, some servers lowercase the values before they send the response, resulting in the x-cert-pinning-signature HTTP header which we later fail to check.

We should lowercase all response headers in the map and compare the lowercase headers.
@petrdvorak petrdvorak added the bug Something isn't working label Nov 23, 2020
@hvge hvge mentioned this issue Nov 24, 2020
Merged
@hvge hvge closed this as completed in #13 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvge hvge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/11 ssl validation strategy wultra/ssl-pinning-ios
2 participants
@petrdvorak @hvge