Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React 18] Automatic batching breaks the Console #14912

Closed
brionmario opened this issue Sep 21, 2022 · 2 comments
Closed

[React 18] Automatic batching breaks the Console #14912

brionmario opened this issue Sep 21, 2022 · 2 comments
Labels
console Console portal application and product API development frontend IceBox Type/Bug

Comments

@brionmario
Copy link
Member

brionmario commented Sep 21, 2022

Describe the issue:
Recently, Console & My Account was migrated to React 18 (PR wso2/identity-apps#3440), and the automatic batching feature seems to interfere with how we handle state in the Console.

  • There are issues when updating Sign On Methods.

How to reproduce:

  1. Go to Console
  2. Navigate to an application's edit page.
  3. Go to Sign on Method tab.
  4. Add a new step.
  5. Click update.
  6. See that the newly added authenticator is not visible unless you navigate to another tab and come back.

Note
It was observed that this behaviour was working as expected in Firefox.

Expected behavior:
React 18 portals should work the same way as the React 16 portals.

Environment information (Please complete the following information; remove any unnecessary fields) :

  • Product Version: IS 6.0.0
  • OS: Mac
  • Database: H2
  • Userstore: LDAP
@brionmario brionmario added Type/Bug console Console portal application and product API development frontend labels Sep 21, 2022
@brionmario
Copy link
Member Author

brionmario commented Sep 21, 2022

As a workaround, the legacy react-dom mode with no batching was used in this PR.
wso2/identity-apps#3471

@brionmario brionmario changed the title [React 18] Automatic batching breaks the Sign On Method behaviour [React 18] Automatic batching breaks the Console Sep 21, 2022
@isharak
Copy link
Member

isharak commented Nov 7, 2024

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Console portal application and product API development frontend IceBox Type/Bug
Projects
None yet
Development

No branches or pull requests

2 participants