PBL + LES restrictions

[davegill]

TYPE: bug fix

KEYWORDS: PBL, LES

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
A few PBL schemes include scalar components that are advected. These fields are
required on all domains. With an LES option on a finer domain, that grid does not
have the additional scalar component, which causes a segfault when trying to
access that field.

Solution:
Restrict what PBL schemes are eligible for use with the LES (no PBL) option.

ISSUE:
Fixes #1514

LIST OF MODIFIED FILES:
modified: Registry/Registry.EM_COMMON
modified: share/module_check_a_mundo.F

TESTS CONDUCTED:

1. When an incompatible CG PBL and FG LES are selected, the code successfully stops.

 &physics
 bl_pbl_physics                      =  5,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  5
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options

 &physics
 bl_pbl_physics                      =  6,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  6
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options

 &physics
 bl_pbl_physics                      = 16,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  16
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options

2. Hopefully we say All jenkins tests are a PASS.

RELEASE NOTE: A test was introduced to stop the incorrect combination of particular PBL schemes on coarser grids with the LES PBL option selected on a finer grid. Previously, this problem caused an inconsistent number of variables on the CG and FG, which caused segmentation faults when trying to do feedback or advection of unavailable fields.

[davegill]

@weiwangncar @dudhia
This PR relies on the assumption that nothing bad happens when we have different fields on different domains. That is not always a great assumption.

[davegill]

@weiwangncar @dudhia
Folks,
This simple mod to check_a_mundo makes sure that only PBL schemes that are NOT (MYNN or EEPS) on the coarser grids are permitted to be used with no PBL on a finer domains. This is ready for review for v4.3.2 inclusion.

[davegill]

@dudhia
Jimy,
What do you think about this PR? Can we code it

[dudhia]

We can leave it as it was (lesscheme?)

…

On Mon, Dec 13, 2021 at 10:01 AM Dave Gill ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Registry/Registry.EM_COMMON <#1596 (comment)>: > @@ -3086,6 +3086,8 @@ package drip sf_surf_irr_alloc==2 - state:irrigat package sprinkler sf_surf_irr_alloc==3 - state:irrigation,irr_rand_field +package lesscheme bl_pbl_physics==0 - - +package nopblscheme bl_pbl_physics==0 - - @dudhia <https://github.com/dudhia> Jimy, I can remove one. Wei asked about if we should call it nopbl or les. We could call it both. What is your preference? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77ANIJS7EF5MNZ7ICDTUQYRH5ANCNFSM5JZKNU4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[weiwangncar]

@davegill @dudhia I'm ok with the decision. But I just wanted to say that sometimes a user could turn off PBL for a test, but it doesn't mean LES is used.

[davegill]

@weiwangncar @dudhia
Wei and Jimy,
I put in some small tweaks (getting rid of the name NOPBLSCHEME, edits to the error message, etc). Because of that, you both need to review again!
Almost there ...

[twjuliano]

@davegill @weiwangncar @dudhia Just a heads up... I am running some single domain simulations using MYNN and am unintentionally catching this error. I was able to fix the issue by adding exists = .FALSE. before looping through domains. Thanks.