fix: added missing properties to the Message type definition #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gekkedev
commented
Jun 26, 2024
gekkedev
commented
Jun 26, 2024
gekkedev
changed the title
gekkedev
changed the title
|
@icleitoncosta could you take a look here as well? I'm getting a lot of TSC errors with a mostly working codebase, i.e.: pls check if my |
Pull Request Summary by devActivityMetrics
Achievements
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where I saw
null, I assumed there could be other values so I added comments as a reminder to specify this later.I have not seen
labelsin any messages, maybe it is already gone instead of just deprecated, so I marked it as optional.