Add Choreo to PathWeaver replacements #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd link to both PathPlanner and Choreo, since Choreo can't do on-the-fly planning while PathPlanner can, and Choreo and PathPlanner have interop. |
|
No library wars pls Just include both? |
That wasn't the intention, Choreo is bundled in the installer whereas pathplanner isnt so imo it made more sense to recommend it. I can link to both |
|
It still reads as pathplanner being an afterthought/lesser alternative |
IMO since choreo is in the installer we should first recommend that then suggest pathplanner if people need features it offers |
spacey-sooty
force-pushed
the
recommend-choreo
branch
from
8e43188
to
86f1e79
Compare
spacey-sooty
changed the title
calcmogul
suggested changes
Oct 16, 2024
jasondaming
reviewed
Oct 16, 2024
spacey-sooty
force-pushed
the
recommend-choreo
branch
2 times, most recently
from
90ea64f
to
3757a01
Compare
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
jasondaming
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.