Skip to content
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.

CommandPS5Controller right joystick always returns -1 #43

Closed
TapChap opened this issue Dec 14, 2023 · 2 comments · Fixed by wpilibsuite/allwpilib#6050
Closed

CommandPS5Controller right joystick always returns -1 #43

TapChap opened this issue Dec 14, 2023 · 2 comments · Fixed by wpilibsuite/allwpilib#6050

Comments

@TapChap
Copy link

TapChap commented Dec 14, 2023

  • When using the methods getRightX() / getRightY() of a CommandPS5Controller object, the returned value is always stuck at -1.
  • in the Driverstation Joystick view, everything seems good,
  • I'm using a PS5 controller IRL (obviously)
  • CommandPS4Controller works fine

I don't have access to a robot at the moment, but If needed i'll have access to one this Sunday (to provide, pictures / log files / code etc)

@ThadHouse
Copy link
Member

It looks like our mapping might be wrong. The triggers and the right stick are swapped. So getLeftTrigger() and getRightTrigger() seem to return what the right stick should be.

@ThadHouse
Copy link
Member

Actually, my controller seems to completely match PS4 controller mappings.

wpilibsuite/allwpilib#5257

Whoever was writing the PR did have different mappings for PS5 and PS4 controllers. So we need to figure out why.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants