-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot be installed in conjunction with 'wp-graphql-woocommerce' #67
Comments
@efoken interesting. As far as I know these plugins should install their dependencies to their own plugin directories, but we can look into it. |
I got the same problem.
|
@jasonbahl If I download the plugins as ZIP file and install them, of course, it works as all plugins have their own |
@efoken is there a way to configure composer.json to make sure these dependencies get installed into their respective project vendor folders? Unless I'm mistaken (@kidunot89 can clarify) WPGraphQL JWT Auth and WPGraphQL for WooCommerce aren't tightly coupled and should be able to run independently or together, regardless of their own composer dependencies. If we could tell composer to install composer dependencies of the JWT plugin under the JWT plugin vendor directory, and the dependencies for WooGraphQL under the WooGraphQL vendor directory, that might solve the issue. If WooGraphQL requires WPGraphQL JWT Auth to be active to use, then perhaps WooGraphQL could just remove the composer dependency altogether, document that WPGraphQL JWT Auth needs to be active, and then call the functions/classes that are included by that plugin being active? I'm not opposed to updating the firebase dependency for this plugin, but I do think the 2 plugins should be able to iterate without a tight coupling to each other if we can make that happen. |
@jasonbahl WooGraphQL using |
@efoken Have you tried deleting your |
@jasonbahl Composer handles dependencies like that, we have only one vendor directory, so only one version of a package can be installed – no matter what. The only solution is to update @kidunot89 I tried ;-) |
I just tried to install this plugin in conjunction with the WPGraphQL WooCommerce addon, but Composer blocks installation because of
firebase/php-jwt
5.0 which is required by 'wp-graphql-woocommerce' and this package required version 4.0Note that I'm using Bedrock with Composer to install WordPress plugins and I'm installing WPGraphQL and addons using GitHub URLs.
Here's what Composer outputs:
The text was updated successfully, but these errors were encountered: