feat: validate bridge_url #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridge_url param will now behave properly with or without trailing slash
performs validation of bridge_url in idkit-core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
m1guelpf
previously requested changes
Jan 17, 2024
|
@m1guelpf as localhost bridge would only work when running IDKit, Bridge, and Simulator all locally, I've add a validation bypass when using a staging app_id and localhost bridge_url |
pdtfh
reviewed
Jan 18, 2024
pdtfh
approved these changes
Jan 18, 2024
Co-authored-by: pdtfh <149602456+pdtfh@users.noreply.github.com>
|
ok to merge from my side |
Merged
Merged
Closed
This was referenced Jul 9, 2024
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates
bridge_urlinidkit-core, fails verification and throws error if:Logs a non-blocking console warning if the
bridge_urlhostname does not end withworldcoin.orgortoolsforhumanity.com-- to be removed once the restriction is lifted in World App.Additionally,
idkit-corenow properly handles trailing slash. Abridge_urlinput as...coin.org/or...coin.orgwill both function properly.